Removed spaces from before ( in core files #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the spaces from before ( in the core CVSanalY files. This is the first step towards getting the code PEP-8 compliant. I had to do this by hand, which is why I haven't done extensions yet. I'm tired! :)
This change must be reviewed carefully around regular expressions. All code changes are syntactically equivalent, but if a space is accidentally removed from the regular expression, it's completely broken. As regexes are not unit tested in the code, we have no way of knowing it's been broken.
Please, please, PLEASE check that regular expressions are the same from the old line to the new line. No regex should have been changed (but
re.compile (...)
is changed tore.compile(...)
, so shows up in the diff).When you are completely sure the regexes haven't changed, then do the merge.
Thanks!