Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed spaces from before ( in core files #52

Merged
1 commit merged into from
Feb 26, 2011
Merged

Removed spaces from before ( in core files #52

1 commit merged into from
Feb 26, 2011

Conversation

cflewis
Copy link

@cflewis cflewis commented Feb 26, 2011

I've removed the spaces from before ( in the core CVSanalY files. This is the first step towards getting the code PEP-8 compliant. I had to do this by hand, which is why I haven't done extensions yet. I'm tired! :)

This change must be reviewed carefully around regular expressions. All code changes are syntactically equivalent, but if a space is accidentally removed from the regular expression, it's completely broken. As regexes are not unit tested in the code, we have no way of knowing it's been broken.

Please, please, PLEASE check that regular expressions are the same from the old line to the new line. No regex should have been changed (but re.compile (...) is changed to re.compile(...), so shows up in the diff).

When you are completely sure the regexes haven't changed, then do the merge.

Thanks!

@linzhp
Copy link
Member

linzhp commented Feb 26, 2011

Double checked with all regexps, no problem.
Merged and closed.
Thanks for the hard working

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants