PULL REQUEST: Update classes to be Python 'new-style' #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 18, 2011 13:48
…. Requires new repositoryhandler version.
linzhp
added a commit
that referenced
this pull request
May 19, 2011
PULL REQUEST: Update classes to be Python 'new-style'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python classes should always inherit from
object. This is referred to as 'new-style', but really this was introduced in 2.2, so it's very old now.If Python classes don't inherit from object, they can display odd behavior, for example things like
__repr__and__str__are not filled in to a sane default without this inheritance.This request also contains a couple changes which abstract out some functions that I needed to override. They're small enough changes that it isn't worth issuing a new Pull Request.