Core(impl): skip log filter when log in chat config disabled (#403)

SrainApp · Feb 11, 2024 · 9fddfc8 · 9fddfc8
1 parent 7c81bed
commit 9fddfc8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/config/reader.c b/src/config/reader.c
@@ -491,6 +491,7 @@ static SrnRet read_server_config_from_cfg(config_t *cfg, SrnServerConfig *srv_cf
 }
 
 static SrnRet read_chat_config_from_chat(config_setting_t *chat, SrnChatConfig *cfg){
+    config_setting_lookup_bool_ex(chat, "log", &cfg->log);
     config_setting_lookup_bool_ex(chat, "notify", &cfg->ui->notify);
     config_setting_lookup_bool_ex(chat, "show-topic", &cfg->ui->show_topic);
     config_setting_lookup_bool_ex(chat, "show-avatar", &cfg->ui->show_avatar);

diff --git a/src/filter/log_filter.c b/src/filter/log_filter.c
@@ -53,6 +53,10 @@ bool filter(const SrnMessage *msg) {
     char *file;
     GString *basename;
 
+    if (!msg->chat->cfg->log) {
+        return TRUE;
+    }
+
     date_str = g_date_time_format(msg->time, "%F");
     g_return_val_if_fail(date_str, TRUE);
 

diff --git a/src/inc/core/chat.h b/src/inc/core/chat.h
@@ -70,7 +70,7 @@ struct _SrnChat {
 };
 
 struct _SrnChatConfig {
-    bool log; // TODO
+    bool log;
     bool render_mirc_color;
     char *password;
     GList *auto_run_cmd_list;