Skip to content

Commit

Permalink
DNSIMPLE: enable Null MX records (#2960)
Browse files Browse the repository at this point in the history
  • Loading branch information
philpennock authored May 16, 2024
1 parent c7975f9 commit df1354b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 0 additions & 2 deletions providers/dnsimple/auditrecords.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import (
func AuditRecords(records []*models.RecordConfig) []error {
a := rejectif.Auditor{}

a.Add("MX", rejectif.MxNull) // Last verified 2023-03

a.Add("TXT", rejectif.TxtLongerThan(1000)) // Last verified 2023-12

a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2023-03
Expand Down
4 changes: 3 additions & 1 deletion providers/dnsimple/dnsimpleProvider.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ func (c *dnsimpleProvider) GetZoneRecords(domain string, meta map[string]string)
r.Name = "@"
}

if r.Type == "CNAME" || r.Type == "MX" || r.Type == "ALIAS" || r.Type == "NS" {
if r.Type == "CNAME" || r.Type == "ALIAS" || r.Type == "NS" {
r.Content += "."
} else if r.Type == "MX" && r.Content != "." {
r.Content += "."
}

Expand Down

0 comments on commit df1354b

Please sign in to comment.