Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support useful functions of javaluator #3049

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Teifun2
Copy link

@Teifun2 Teifun2 commented Feb 24, 2025

This PR is in reference of #2785. It now contains a subset of functions only that can be relevant when selecting pages in "Custom Page Order".

Description of Changes

Please provide a summary of the changes, including:

The matcher now accepts all these functions / symbols

  • Why the change was made
    Functions like modulo, abs, floor, ceil, can be vital for reordering properly. This should now be possible.

  • Any challenges encountered
    Finding the documentation of the underlying expression / what is possible or not.


Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Feb 24, 2025
@github-actions github-actions bot added the Java Pull requests that update Java code label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Java Pull requests that update Java code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant