Strawberry perl 5.40.1.1, 5.38.3.1, 5.34.3.1 #233

shawnlaffan · 2025-01-22T00:21:52Z

Updates #231 and #124

Otherwise we get errors like ``` ..\perl.exe -f ..\pod\buildtoc -q ..\pod\buildtoc: perl5401delta.pod is known by buildtoc but does not exist ..\pod\buildtoc: Can't open file 'pod/perl5401delta.pod' for perl5401delta: No such file or directory ABORTED ```

We get many test failures with -O2 -fno-inline-functions

Also use libxslt 1.1.39 built with that version of libxml2. Its version is unchanged.

This allows consistency with 5.40.0.

Temporary code as a proof of concept. Should either be its own step or an optional argument.

Was a copy-paste error

Adding comments causes downstream issues with a few CPAN mods.

This makes it more obvious that a module is upgraded. Something in the code is uninstalling the original, which might not be what we want.

csjewell · 2025-01-30T04:43:43Z

lib/Perl/Dist/Strawberry/Step/UpgradeCpanModules.pm

@@ -29,7 +29,7 @@ sub run {
    # Now go through the loop for each module.
    my $i = 0;
    for my $module (@list) {
-      my $item = { module=> $module->{cpan_file}, install_to=>'perl' };


This was deliberate on my part "back in the day..."

Given that, why would we want to pack up and install two versions of the same module?

Thanks for noting this. FWIW, I had assumed it was deliberate.

The original motivation for the latest change is in #221 where the Socket build differs when built with core or from CPAN. Perl 5.40 came with the latest version of Socket so it was not updated in the CPAN update step of the SP build.

Having run a few dev builds with this set, the P::D::S code is uninstalling the core modules first so we don't actually package both versions. The directories are left behind, though. I also have not yet tracked down where the uninstall is happening.

The original motivation for the latest change is in #221

I think you could alternatively apply the patch at Perl/perl5@0404e25 - though I'm not sure whether that would count as an improvement over your current option ;-)

I don't know why that PR has not been merged. I presume it's just part of the general arrogant and apathetic disregard for Windows, but maybe it actually poses some problem of which I'm unaware.
I've been using that patch without any issue in my monthly builds of devel perl (beginning with perl-5.41.4 or perl-5.41.5), and it seems to be working fine. (My testing of the functionality is, however, not rigorous.)

I think there are a number of other symbols in those Windows config files that could and should also be defined - but I don't feel confident of being able to correctly identify them.
Besides, if the changes identified by that patch are being ignored, then I don't see much point in identifying other candidates for alteration.

We are changing some of the related defines before the build. If there are good reasons then we can add more.

Perl-Dist-Strawberry/share/64bit-5.40.1.1.pp

Lines 94 to 113 in 56d14cc

'config_H.gc' => {

I_DBM => 'define',

I_GDBM => 'define',

I_NDBM => 'define',

HAS_BUILTIN_CHOOSE_EXPR => 'define',

HAS_SYMLINK => 'define',

HAS_ISFINITE => 'define', # part of https://github.com/Perl/perl5/pull/22257

},

'config.gc' => { # see Step.pm for list of default updates

d_builtin_choose_expr => 'define',

d_mkstemp => 'define',

d_ndbm => 'define',

d_symlink => 'define', # many cpan modules fail tests when defined

i_db => 'define',

i_dbm => 'define',

i_gdbm => 'define',

i_ndbm => 'define',

d_isfinite => 'define', # part of https://github.com/Perl/perl5/pull/22257

osvers => '10',

},

Installing updated core modules to the vendor dir has the advantage that it is then clear that they are not the versions distributed with that version of perl.

@csjewell raises the valid point that we might be distributing two versions of the same module. This could lead to confusion if users manually set the PERL5LIB paths and switch the order of the perl\vendor\lib and perl\lib dirs, but the build system seems to be uninstalling from perl\lib so this problem should not manifest on users systems. (This does need to be more thoroughly checked, though).

Coming back to Socket, an alternative approach is to force a rebuild in one of the CPAN install steps.

Currently two settings, one for core, one for cpan.

Build core with the same set as SP 5.40.0.1, and CPAN with -O2. See discussion and links in #232

This makes it clearer when the core was built with different flags than the CPAN modules.

Skip tests that fail due to path lengths, rather than all tests.

This allows separate release notes for the PDL edition, for example.

This hopefully makes it clearer it is not a standard perl entry.

shawnlaffan · 2025-02-25T02:14:24Z

Just an update.

I have a 5.34.3 build that can be released and will do so later this week.

The 5.38.3 and 5.40.1 releases are waiting on resolution of Perl/perl5#23022, and related patching of the SP builds.

shawnlaffan added 7 commits January 22, 2025 11:20

Config files for strawberry perl 5.40.1

1e1ed54

Provide GNUMakefile for 5.40.1

0afab71

Otherwise we get errors like ``` ..\perl.exe -f ..\pod\buildtoc -q ..\pod\buildtoc: perl5401delta.pod is known by buildtoc but does not exist ..\pod\buildtoc: Can't open file 'pod/perl5401delta.pod' for perl5401delta: No such file or directory ABORTED ```

Makefile for 5.40.1 - revert optimisation change

a7a163c

We get many test failures with -O2 -fno-inline-functions

5.40.1 config: use libxml2-2.12.9

3fab675

Also use libxslt 1.1.39 built with that version of libxml2. Its version is unchanged.

5.40.1: disable Imager-File-TIFF for now

2442485

5.40.1 config: install newly non-core PDL modules

43fdf3d

This allows consistency with 5.40.0.

Override optimize flag in Config_heavy.pl

cc5cf66

Temporary code as a proof of concept. Should either be its own step or an optional argument.

shawnlaffan force-pushed the sp5.40.1 branch from 7be6fcd to cc5cf66 Compare January 23, 2025 01:55

shawnlaffan added 4 commits January 24, 2025 09:36

Fix libwebp download link

c197254

Was a copy-paste error

Simplify optimize override

2afa323

Adding comments causes downstream issues with a few CPAN mods.

Cpan upgrade step: install to vendor

45c9fc9

This makes it more obvious that a module is upgraded. Something in the code is uninstalling the original, which might not be what we want.

5.40.1 config: Rearrange PDL deps, reinstate PDL::IO::GD

27249cd

shawnlaffan changed the title ~~Strawberry perl 5.40.1~~ Strawberry perl 5.40.1.1 Jan 30, 2025

csjewell reviewed Jan 30, 2025

View reviewed changes

shawnlaffan added 6 commits January 31, 2025 09:43

Use config args to control optimization flags

d0774de

Currently two settings, one for core, one for cpan.

5.40.1.1 config: set optimize flags

56d14cc

Build core with the same set as SP 5.40.0.1, and CPAN with -O2. See discussion and links in #232

Add config_heavy entry for perl_optimize_core

bc538b0

This makes it clearer when the core was built with different flags than the CPAN modules.

5.40.1.1: skip specific PDL tests

0f62eab

Skip tests that fail due to path lengths, rather than all tests.

Support suffix arg in CreateReleaseNotes step

e202d33

This allows separate release notes for the PDL edition, for example.

5.40.1.1 config: Create PDL edition distribution list and release notes

a62268e

shawnlaffan mentioned this pull request Jan 31, 2025

release notes: build for PDL editions #203

Open

shawnlaffan added 2 commits February 4, 2025 18:52

Configs for 5.38.3.1

7e2a47f

Config and script for 5.34.3.1 beta

907ca35

shawnlaffan changed the title ~~Strawberry perl 5.40.1.1~~ Strawberry perl 5.40.1.1, 5.38.3.1, 5.34.3.1 Feb 5, 2025

shawnlaffan added 2 commits February 5, 2025 20:23

5.34.3.1 config: add step to create JSON snippet

748e485

prefix the optimize_core_build config entry with "my_"

2795459

This hopefully makes it clearer it is not a standard perl entry.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Strawberry perl 5.40.1.1, 5.38.3.1, 5.34.3.1 #233

Strawberry perl 5.40.1.1, 5.38.3.1, 5.34.3.1 #233

shawnlaffan commented Jan 22, 2025 •

edited

Loading

csjewell Jan 30, 2025

shawnlaffan Jan 30, 2025

sisyphus Jan 31, 2025

shawnlaffan Jan 31, 2025

shawnlaffan commented Feb 25, 2025

	'config_H.gc' => {
	I_DBM => 'define',
	I_GDBM => 'define',
	I_NDBM => 'define',
	HAS_BUILTIN_CHOOSE_EXPR => 'define',
	HAS_SYMLINK => 'define',
	HAS_ISFINITE => 'define', # part of https://github.com/Perl/perl5/pull/22257
	},
	'config.gc' => { # see Step.pm for list of default updates
	d_builtin_choose_expr => 'define',
	d_mkstemp => 'define',
	d_ndbm => 'define',
	d_symlink => 'define', # many cpan modules fail tests when defined
	i_db => 'define',
	i_dbm => 'define',
	i_gdbm => 'define',
	i_ndbm => 'define',
	d_isfinite => 'define', # part of https://github.com/Perl/perl5/pull/22257
	osvers => '10',
	},

Strawberry perl 5.40.1.1, 5.38.3.1, 5.34.3.1 #233

Are you sure you want to change the base?

Strawberry perl 5.40.1.1, 5.38.3.1, 5.34.3.1 #233

Conversation

shawnlaffan commented Jan 22, 2025 • edited Loading

csjewell Jan 30, 2025

Choose a reason for hiding this comment

shawnlaffan Jan 30, 2025

Choose a reason for hiding this comment

sisyphus Jan 31, 2025

Choose a reason for hiding this comment

shawnlaffan Jan 31, 2025

Choose a reason for hiding this comment

shawnlaffan commented Feb 25, 2025

shawnlaffan commented Jan 22, 2025 •

edited

Loading