handle error for plugin that exits before ping established

TBD54566975 · Oct 11, 2024 · 8e32669 · 8e32669
1 parent a30b52a
commit 8e32669
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/internal/buildengine/languageplugin/external_plugin_client.go b/internal/buildengine/languageplugin/external_plugin_client.go
@@ -81,8 +81,12 @@ func (p *externalPluginImpl) start(ctx context.Context, bind *url.URL, language
 		close(pingErr)
 	}()
 
+	// Wait for ping result, or for the plugin to exit. Which ever happens first.
 	select {
 	case err := <-cmdErr:
+		if err == nil {
+			return fmt.Errorf("plugin exited with status 0 before ping was registered")
+		}
 		return err
 	case err := <-pingErr:
 		if err != nil {