Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Feat/todo #199

Merged
merged 78 commits into from
Oct 10, 2024
Merged

Feat/todo #199

merged 78 commits into from
Oct 10, 2024

Conversation

Johnnyevans32
Copy link
Contributor

@Johnnyevans32 Johnnyevans32 commented Oct 7, 2024

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ New Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 👷 Example Application
  • 🧑‍💻 Code Snippet
  • 🎨 Design
  • 📖 Content
  • 🧪 Tests
  • 🔖 Release
  • 🚩 Other

Description

This PR integrates the todo component with web5.

Related Tickets & Documents

Resolves #74
Resolves #68

Mobile & Desktop Screenshots/Recordings

Screen.Recording.2024-10-09.at.01.mp4

Added code snippets?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

No tests? Add a note

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 general documentation
  • 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@Johnnyevans32 Johnnyevans32 marked this pull request as ready for review October 8, 2024 23:53
@Johnnyevans32
Copy link
Contributor Author

@blackgirlbytes @leordev @acekyd this is ready for review

@blackgirlbytes
Copy link
Contributor

hey do you think there can be an edit button added? I see that clicking on it will edit the to do but can it more closely match the react vite project? Thank you @Johnnyevans32 !

@Johnnyevans32
Copy link
Contributor Author

@blackgirlbytes done i added an edit button now

Copy link
Contributor

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Thanks for the contribution!

@blackgirlbytes blackgirlbytes merged commit 74650c1 into TBD54566975:main Oct 10, 2024
20 of 21 checks passed
@blackgirlbytes
Copy link
Contributor

Hey @taniashiba ..after we remove the leaderboard action from github..we need to manually add 10 points for @Johnnyevans32 to the leaderboard because this PR he did two issues in one..a large and a medium

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create to do list page component - Vue Create home page component - Vue
2 participants