Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow global install and use external modules #120

Merged
merged 17 commits into from
Dec 3, 2016
Merged

Allow global install and use external modules #120

merged 17 commits into from
Dec 3, 2016

Conversation

cebe
Copy link
Member

@cebe cebe commented Mar 21, 2016

currently it is not possible to install uipf on a system with make install and also other modules which are not directly located in uipf development directory can not be used.
This pull request adds some changes to improve the situation. It is work in progress and should not be merged.

  • Add install targets ot CMakeLists.txt

  • Change ModuleManager to be able to load modules from different locations

  • open bug (opencv waitkey does not work in console module):

    uipf: symbol lookup error: /Code/build/libVisualizationModule.so: undefined symbol: _ZN2cv7waitKeyEi
    
  • fix chdir() issue for console too (to make relative paths in yaml files work)

  • Add Documentation on how to load modules

  • Add Documentation on how to compile external modules

@akarsh
Copy link
Contributor

akarsh commented Mar 22, 2016

Is the issue OS environment specific or library dependency or file path miss match specific in a brief overview ?
I can test on Mac OS
if you want to have overview.
As, i installed opencv library with XCODE & I have a small test with cmakelists successful to check for blurrying an image through console arguments.

cmake_minimum_required(VERSION 2.8)
project( BlurImage )
find_package( OpenCV )
include_directories( ${OpenCV_INCLUDE_DIRS} )
add_executable( BlurImage BlurImage.cpp )
target_link_libraries( BlurImage ${OpenCV_LIBS} )

@cebe
Copy link
Member Author

cebe commented Mar 23, 2016

these changes might fix the issue described in #114 so you might try to install on mac again. however the make install command may not install it to the correct directories as I do not know where to best store things on mac. But maybe CMake already handles this correctly...

@cebe cebe added this to the 1.0.0-beta2 milestone Mar 23, 2016
cebe added 8 commits March 23, 2016 15:17
atof() depends on the locale, which means, that on systems with e.g. de_DE,
parameters with dot as decimal symbol are not parsed correctly because atof() expects
a comma instead.
This fixes it to use dot always.

See also http://stackoverflow.com/questions/1333451/locale-independent-atof?lq=1
this allows opening yaml files from applications in gnome and KDE and also
opening them from the file browser.
this is needed to make relative paths in the yaml file work.
@cebe cebe merged commit c253ce2 into master Dec 3, 2016
cebe added a commit that referenced this pull request Dec 3, 2016
* global-install:
  docs about compiling a module
  chdir to the yaml file when loading a config to make relative paths work
  exclude IDEA cmake build
  build with optimization
  GUI chdir to current yaml file
  ensure console command can run on a server without display.
  added .desktop files
  Locale independent parameter parsing
  improved logging output
  make Context work in external modules
  improved exception catching
  make types const compatible
  fixed another "missing symbol" error
  Update extending-modules.md
  enhance datatype constructors
  make external modules work
  allow uipf to be installed globally

Conflicts:
	README.md
@cebe cebe deleted the global-install branch December 3, 2016 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants