Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(react-router): e2e scroll restoration reproducers #2205

Closed
wants to merge 3 commits into from

Conversation

Copy link

nx-cloud bot commented Aug 27, 2024

View your CI Pipeline Execution ↗ for commit 8588738.

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-31 02:44:34 UTC

Copy link

pkg-pr-new bot commented Aug 27, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@2205

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@2205

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@2205

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@2205

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@2205

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@2205

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@2205

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@2205

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@2205

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@2205

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@2205

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@2205

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@2205

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@2205

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@2205

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@2205

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@2205

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@2205

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@2205

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@2205

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@2205

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@2205

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@2205

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@2205

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@2205

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@2205

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@2205

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@2205

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@2205

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@2205

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@2205

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@2205

commit: 8588738

@SeanCassiere SeanCassiere changed the title test: reproducer for #2014 test: scroll restoration reproducers Aug 27, 2024
@SeanCassiere SeanCassiere changed the title test: scroll restoration reproducers test(react-router): scroll restoration reproducers Aug 27, 2024
@SeanCassiere SeanCassiere changed the title test(react-router): scroll restoration reproducers test(react-router): e2e scroll restoration reproducers Aug 27, 2024
@schiller-manuel schiller-manuel marked this pull request as ready for review October 27, 2024 22:25
@schiller-manuel schiller-manuel marked this pull request as draft October 27, 2024 22:25
@SeanCassiere
Copy link
Member Author

Looks like this PR is no longer needed since everything is already available on "main" with the merging of #3191.

@SeanCassiere SeanCassiere deleted the scroll-restoration-bugs branch January 31, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants