-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router-generator): reset route-group Regex when calling handleNode
#3289
fix(router-generator): reset route-group Regex when calling handleNode
#3289
Conversation
View your CI Pipeline Execution ↗ for commit 5a8b7e6.
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/create-router
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/create-start
@tanstack/react-cross-context
@tanstack/react-router
@tanstack/react-router-with-query
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/start
@tanstack/start-api-routes
@tanstack/start-config
@tanstack/start-client
@tanstack/start-plugin
@tanstack/start-router-manifest
@tanstack/start-server
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-handler
@tanstack/start-server-functions-server
@tanstack/start-server-functions-ssr
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
@SeanCassiere thank you so much, that was relatively was quick, I was hesitant to open an issue, I thought, there was something I didn't grasp yet |
It was certainly a weird one 😅 |
This was a weird one 🤔.
Since the Regex we use for checking if a "route-node" is a possible "route-group" uses the global flag, it carries some state across runs. As such, it falsly returned
false
(instead oftrue
) on some nodes that were in fact representing a "route-group".Closes #3280