Go: Add /db handler.

[kardianos]

Adds a DB handler to the go source. You may need to add another command:
go get -u .
in your scrip to get the mysql driver library.

[tarndt]

Code LGTM

[bhauer]

Thanks for this, @kardianos! We have wanted a db test for Go for a while but never managed to get it done. We'll work to get this tested and accepted as soon as possible.

[tarndt]

@kardianos @bhauer

What about running the queries in parallel?

ww := make([]World, qnum)
var done sync.WaitGroup
done.Add(qnum)
for i := 0; i < qnum; i++ {
    go func(idx int) {
        defer done.Done()
        q.QueryRow(rand.Intn(DB_ROWS)+1).Scan(&ww[idx].Id, &ww[idx].RandomNumber)
    }(i)
}
done.Wait()

[kardianos]

This doesn't actually speed things up.

The http handler is already called in parallel. I've got them coded
side by side with a flag to switch between parallel and sequential if
you want it. But either way, I think you would want to be slightly
smarter about spawning go-routines, with a http concurrency of X and a
DB concurrency of Y, you will spawn and collect X * Y short lived
go-routines. That's a lot of memory allocations, even if though
go-routine are small. There might be a smart way to speed things up
and make more run in parallel. In such trivial code and sql, I really
don't care about it personally.

On Mon, Apr 8, 2013 at 9:57 AM, Tylor Arndt [email protected] wrote:

@kardianos @bhauer

What about running the queries in parallel?

ww := make([]World, qnum)
var done sync.WaitGroup
done.Add(qnum)
for i := 0; i < qnum; i++ {
go func() {
defer done.Done()
q.QueryRow(rand.Intn(DB_ROWS)+1).Scan(&ww[i].Id,
&ww[i].RandomNumber)
}()
}
done.Wait()

—
Reply to this email directly or view it on GitHub.

[tarndt]

@kardianos : Thanks, I wasn't really suggesting that the above would be actual code to use, but I wanted to check to see if you had tested it in a parallel fashion, and it sounds like you have. Thanks for being thorough.

Once this is committed, I'm going to play with it and see if I can manage to make it faster.

[kardianos]

@tarndt If you want to make it faster, use the vitess driver directly.

[pfalls1]

Thanks @kardianos! It's nice to finally have a database test for Go.