Feat/agents integration #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: added unit tests for core provider. small bugfix on calculate_metrics of provider * added unit tests and docstring for join chunks * added unit tests and docstrings for calculate_cost on provider * added unit tests and docstrings for input_to_string on provider * added unit tests and docstrings for chat and achat * added unit tests and docstrings for chat and achat * chore: cleaned provider unit tests * chore: separated provider tests into different files. fixed some of its tests * chore: linted code * chore: deleted some comments * chore: linted * chore: Added Azure Provider Unit Tests (#176) * chore: added unit tests for azure provider * chore: added more unit tests and docstrings on azure, removed redundant comments * chore: added unit tests for generate client on Azure Provider * chore: separated azure unit tests into separate files. fixed some of its tests. * chore: linted code * chore: new line Signed-off-by: Diogo Goncalves <[email protected]> --------- Signed-off-by: Diogo Goncalves <[email protected]> Co-authored-by: Diogo Goncalves <[email protected]>
* [feat] prompt management * [feat] testing * [feat] only one active prompt
## LLMstudio Version X.X.X ### What was done in this PR: - ... ### How it was tested: - ... ### Additional notes: - Any breaking changes? - Any new dependencies added? - Any performance improvements?
Signed-off-by: Diogo Goncalves <[email protected]>
## LLMstudio Version X.X.X ### What was done in this PR: - Add bedrock agents ### How it was tested: - ... ### Additional notes: - Any breaking changes? - Any new dependencies added? - Any performance improvements?
## LLMstudio Version X.X.X ### What was done in this PR: - ... ### How it was tested: - ... ### Additional notes: - Any breaking changes? - Any new dependencies added? - Any performance improvements?
## LLMstudio Version X.X.X ### What was done in this PR: - ... ### How it was tested: - ... ### Additional notes: - Any breaking changes? - Any new dependencies added? - Any performance improvements?
claramoreirag
commented
Feb 11, 2025
|
|
||
| def run_agent( | ||
| self, | ||
| openai_agent: OpenAIAgent, |
There was a problem hiding this comment.
instead of calling the param 'openai_agent' it should be just 'agent', to use the 2 agents interchangeably
also we should discuss between having it like this (with the 2 params) or wrapping it in a RunAgentRequest, which is what I did for bedrock
claramoreirag
commented
Feb 11, 2025
|
|
||
| return openai_run | ||
|
|
||
| def retrieve_result(self, openai_run: OpenAIRun) -> OpenAIResult: |
There was a problem hiding this comment.
instead of 'openai_run' , just 'run'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLMstudio Version X.X.X
What was done in this PR:
How it was tested:
Additional notes: