mpl: fix fixed terminals for cluster of unplaced IOs #6689
+107
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Koucher <[email protected]>
…side SA Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
…ments Signed-off-by: Arthur Koucher <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Arthur Koucher <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Running Secure-CI |
maliberty
approved these changes
Feb 11, 2025
|
Code is ok; waiting on CI to merge |
|
The failure in the regression test seems to triggered by a bug that is not related to the changes here. However, it needs fixing before this PR gets merged. I'm working on it. |
This was referenced Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6668
What is Wrong
In the context of the WL computation inside SA for the cluster of unconstrained pins, the distance to boundary is being wrongly computed, because we're using the shape of its Cluster object which does not take into account the offset w.r.t. the current outline.
Context and Changes
Originally, a fixed terminal in HierRTLMP was just a Soft/Hard Macro with the shape of a point (area = 0).
With the new IOs' abstraction implemented in #5809, for clusters of unplaced IOs, we need to have a Soft/Hard Macro object with a proper shape inside SA in order to compute the distance to the closest boundary correctly.
As this needs to happen for both cluster placement (Soft) and macro placement (Hard) I made the constructors used to create fixed terminals in both Hard/Soft Macro have the same arguments to be able to template the function that uses these constructors.
I.e., this PR ensures that, inside SACore, for a WL computation in which one of the objects is a cluster of unplaced IOs: