Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsz: modify default verbose behavior of repair design and repair timing #6732

Merged

Conversation

gudeh
Copy link
Contributor

@gudeh gudeh commented Feb 18, 2025

always print first and last iteration, only print middle ones when verbose is active

always print first and last iteration, only print middle ones when verbose is active

Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gudeh gudeh requested a review from precisionmoon February 18, 2025 22:45
Copy link
Contributor

@precisionmoon precisionmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Thanks.

@maliberty
Copy link
Member

Some tests need fixing

auto-merge was automatically disabled February 19, 2025 09:05

Head branch was pushed to by a user without write access

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Augusto Berndt <[email protected]>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus eder-matheus merged commit ea8ad80 into The-OpenROAD-Project:master Feb 19, 2025
11 checks passed
@gudeh gudeh deleted the rsz-modify-verbose-default branch February 19, 2025 15:00
@gudeh
Copy link
Contributor Author

gudeh commented Feb 19, 2025

In ORFS, we opted to keep the default verbosity of RSZ repair design and repair timing to true (as in flow/scripts/util.tcl). However, if an ORFS user sets the verbosity to false, they will now see messages for the first and last iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants