Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cstdint header to all files using fixed width integers #2717

Open
wants to merge 77 commits into
base: master
Choose a base branch
from

Conversation

realstealthninja
Copy link
Collaborator

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: fixes #2710

@realstealthninja
Copy link
Collaborator Author

realstealthninja commented Aug 31, 2024

I understand one big pr is frowned upon but opening 81 seperate prs seems very unnecessary.
the files you see with large diffs are due to the linting done by the ide so it fits clang tidy

@realstealthninja
Copy link
Collaborator Author

Going to stick with integral typedefs since iwyu doesnt seem to work for me. We can implement that as a later pr. For now the most important thing is to fix the compilation issue, documentation can wait

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned earlier: I would suggest to remove the /// for integral typedefs part.

@realstealthninja
Copy link
Collaborator Author

Oh yes forgot that thanks for reminding me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Correction to existing algorithms ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] gcc >= 13 reordered headers.
3 participants