-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add cstdint header to all files using fixed width integers #2717
base: master
Are you sure you want to change the base?
Conversation
I understand one big pr is frowned upon but opening 81 seperate prs seems very unnecessary. |
This reverts commit f212745.
This reverts commit a290ae7.
This reverts commit 19d136a.
This reverts commit 5dd7f82.
This reverts commit 8a8fd42.
This reverts commit eff2f44.
This reverts commit c47117c.
This reverts commit c3897d3.
This reverts commit 0c6611a.
This reverts commit dabd6d2.
This reverts commit 740bd65.
This reverts commit 16ee49e.
This reverts commit a3b719e.
This reverts commit 24e597f.
This reverts commit 3d80295.
This reverts commit 7edcb6e.
This reverts commit f0a30d7.
Going to stick with integral typedefs since iwyu doesnt seem to work for me. We can implement that as a later pr. For now the most important thing is to fix the compilation issue, documentation can wait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned earlier: I would suggest to remove the /// for integral typedefs
part.
Oh yes forgot that thanks for reminding me |
Description of Change
Checklist
Notes: fixes #2710