Fixing grammatical mistakes, typos, and adding description to the Viterbi algorithm #38

SatinWukerORIG · 2023-06-22T06:16:29Z

No description provided.

ZoomRmc · 2023-06-22T12:22:36Z

CONTRIBUTING.md

 - On the other hand, write generic code where appropriate. Do not impose arbitrary limitations if the code can work on a wider range of data types.
- Don't use unsigned numerical types (`uint` and its sized variants), unless wrapping behaviour or binary manipulation is required for the algorithm.
+- Don't use unsigned numerical types (`uint` and its sized variants), unless wrapping behavior or binary manipulation is required for the algorithm.


This is an international collaboration, so enforcing US spelling in docs is debatable (for symbols it's ok due to tradition).

Had I to choose, I would prefer UK spelling and grammar rules. US spelling/grammar feels omnipresent.
As a French speaker, I often mix US/UK usages. Usually, I use Grammarly to help me correct my syntax, but I did not use it for writing the CONTRIBUTING.md file.

ZoomRmc · 2023-06-22T12:26:22Z

Thanks a lot for the fixes, receiving a human read-through is invaluable!

dlesnoff

Very nice spelling improvement.
Please either rebase or create a new branch before each of your pull requests.
Your git log is a mess. It is making it hard to follow your changes.

dlesnoff · 2023-06-22T12:41:45Z

CONTRIBUTING.md

@@ -29,7 +29,7 @@ An Algorithm is one or more functions that:
 - return one or more outputs,
 - have minimal side effects (Examples of side effects: `echo()`, `rand()`, `read()`, `write()`).

-## Contributor agreement
+## Contributor Agreement


We should have a consistent rule for titles.

I propose lowercasing all but the first letter. That is the rule that I use in my research papers. Revert this change and lowercase all the other titles.

dlesnoff · 2023-06-22T12:44:40Z

dynamic_programming/catalan_numbers.nim

    The Catalan numbers are a sequence of natural numbers that occur in the
-    most large set of combinatorial problems.
+    the largest set of combinatorial problems.


We can never know in advance how many combinatorial sets of problems we will discover. Maybe we will find one more general than Catalan numbers in the future. Just let's rephrase this to say that it is very frequent.

dlesnoff · 2023-06-22T12:46:44Z

dynamic_programming/viterbi.nim

+## Time Complexity: O(K2n)
+## Space Complexity: O(Kn)


What is K and what is n?
Why one is lowercase and not the other?
Drop the constant in the time complexity. If you insist on the constant, put it in front.

dlesnoff · 2023-06-22T12:47:47Z

dynamic_programming/viterbi.nim

+##
+## Time Complexity: O(K2n)
+## Space Complexity: O(Kn)
+## https://www.cs.cmu.edu/~epxing/Class/10708-20/scribe/lec4_scribe.pdf


Move the Wikipedia link under this link.

dlesnoff · 2023-06-22T12:49:02Z

dynamic_programming/viterbi.nim

@@ -1,4 +1,14 @@
 # Viterbi
+## The Viterbi algorithm is a dynamic programming algorithm
+## for obtaining the maximum a posteriori probability estimate
+## of the most likely sequence of hidden states


Suggested change

## of the most likely sequence of hidden states

## of the most likely sequence of hidden states in a hidden Markov model.

Fixing grammatical mistakes

By Grammarly

Adding description and reference to the Viterbi Algorithm

* Add a sample of maths basic algorithms * Update maths/abs.nim Co-authored-by: Zoom <[email protected]> * Use openArray in absMaxSort Co-authored-by: Zoom <[email protected]> * Fix seq->openArray and int->SomeInteger * Use Positive as input instead * Update maths/addition_without_arithmetic.nim Co-authored-by: Pietro Peterlongo <[email protected]> * Name allocation number * [maths/abs] Replace maxAbsSort by signed[Min/Max]Abs * [Aliquot Sum] Add header * Add empty line at end of file * Remove Allocation number since it is a non standard algorithm * Fix titles * Run nimpretty on the files * Rename file and add DIRECTORY.md * abs: Fix variable name * Add export marker Co-authored-by: Zoom <[email protected]> * Add RE block in aliquot sum and improve RE Co-authored-by: Zoom <[email protected]> * Remove MD quotation marks for inline code * Add export marker for RE block * Remove extra ValueError --------- Co-authored-by: Dimitri LESNOFF <[email protected]> Co-authored-by: Zoom <[email protected]> Co-authored-by: Pietro Peterlongo <[email protected]> Co-authored-by: David Leal <[email protected]>

* Use a dynamic allocated array (sequence) for strings * Run nimpretty * Add requested changes * Fix documentation generation * Fix test title according to changes Co-authored-by: Satin Wuker <[email protected]> * Update comments to warn about indexing issues Modified a bit the suggestions of comments. Please check them before approving. Co-authored-by: Zoom <[email protected]> --------- Co-authored-by: Dimitri LESNOFF <[email protected]> Co-authored-by: Satin Wuker <[email protected]> Co-authored-by: Zoom <[email protected]>

…hms#41) This will run `sudo apt-get update` before running any other commands on the Gitpod prebuild image (`.gitpod.dockerfile`).

…s#42) * Update README.md Use more extended markdown syntax instead of HTML, Add Matrix links Superseed PR TheAlgorithms#40 * Actually fix gitter! Move img src links to footer. Also changed the TheAlgorithms logo image link. * Restore TheAlgorithms logo link * More link fixes --------- Co-authored-by: dlesnoff <[email protected]>

dlesnoff · 2023-06-27T09:52:31Z

Please, look at the edit below.

I made a huge error on your branch. I tried to rebase and force push to remove these commits about linear search and bubble sort. By doing so, I put new commits that were not on your branch on top of yours, thus modifying the commit timestamps.
If your local repo is still fine, just git push --force.
I wanted to rebase all these old commits you had.
You will have to remove these by rebasing.
Just use after the forced push and the rebasing with main, you should rebase your local repo: git rebase -i origin/main and delete all these commits for linear search and bubble sort.
This will make the commit history cleaner (and the commit description shorter).
The problem is, that you will have to put your commits on top of those on the main branch and git push --force at some point.

EDIT: I think that merging with main solved the issue.

SatinWukerORIG requested review from Panquesito7 and dlesnoff as code owners June 22, 2023 06:16

ZoomRmc reviewed Jun 22, 2023

View reviewed changes

dlesnoff reviewed Jun 22, 2023

View reviewed changes

Panquesito7 added the documentation Improvements or additions to documentation label Jun 23, 2023

SatinWukerORIG and others added 12 commits June 27, 2023 11:44

Update CONTRIBUTING.md

11e3f84

Fixing grammatical mistakes

Update check_anagram.nim, fixing grammar

51558e6

By Grammarly

Update catalan_numbers.nim, fixing typos

56ae4c7

Update viterbi.nim

c72bb73

Adding description and reference to the Viterbi Algorithm

Add arc length (TheAlgorithms#10)

41915d6

chore: run apt-get update before running other commands (TheAlgorit…

07bfb63

…hms#41) This will run `sudo apt-get update` before running any other commands on the Gitpod prebuild image (`.gitpod.dockerfile`).

fix: nimpretty for arc_length.nim (TheAlgorithms#43)

4dac603

chore: gc->mm, move back to config.nims (TheAlgorithms#47)

1fb03e8

chore: revert TheAlgorithms#41 (TheAlgorithms#45)

8e61829

dlesnoff force-pushed the main branch from a5c9904 to 8e61829 Compare June 27, 2023 09:49

Merge branch 'main' into main

b820002

dlesnoff mentioned this pull request Jun 29, 2023

docs: add missing # #50

Merged

dlesnoff added 3 commits June 29, 2023 13:55

Merge branch 'main' into main

bcbee6f

Merge branch 'main' into main

b8f4c8f

Merge branch 'main' into main

47c2992

Panquesito7 requested a review from dlesnoff September 8, 2023 19:34

dlesnoff mentioned this pull request Sep 10, 2023

Update CONTRIBUTING.md #59

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing grammatical mistakes, typos, and adding description to the Viterbi algorithm #38

Fixing grammatical mistakes, typos, and adding description to the Viterbi algorithm #38

SatinWukerORIG commented Jun 22, 2023

ZoomRmc Jun 22, 2023

dlesnoff Jun 22, 2023

ZoomRmc commented Jun 22, 2023 •

edited

Loading

dlesnoff left a comment

dlesnoff Jun 22, 2023 •

edited

Loading

dlesnoff Jun 22, 2023

dlesnoff Jun 22, 2023 •

edited

Loading

dlesnoff Jun 22, 2023

dlesnoff Jun 22, 2023

dlesnoff commented Jun 27, 2023 •

edited

Loading

	## of the most likely sequence of hidden states
	## of the most likely sequence of hidden states in a hidden Markov model.

Fixing grammatical mistakes, typos, and adding description to the Viterbi algorithm #38

Are you sure you want to change the base?

Fixing grammatical mistakes, typos, and adding description to the Viterbi algorithm #38

Conversation

SatinWukerORIG commented Jun 22, 2023

ZoomRmc Jun 22, 2023

Choose a reason for hiding this comment

dlesnoff Jun 22, 2023

Choose a reason for hiding this comment

ZoomRmc commented Jun 22, 2023 • edited Loading

dlesnoff left a comment

Choose a reason for hiding this comment

dlesnoff Jun 22, 2023 • edited Loading

Choose a reason for hiding this comment

dlesnoff Jun 22, 2023

Choose a reason for hiding this comment

dlesnoff Jun 22, 2023 • edited Loading

Choose a reason for hiding this comment

dlesnoff Jun 22, 2023

Choose a reason for hiding this comment

dlesnoff Jun 22, 2023

Choose a reason for hiding this comment

dlesnoff commented Jun 27, 2023 • edited Loading

ZoomRmc commented Jun 22, 2023 •

edited

Loading

dlesnoff Jun 22, 2023 •

edited

Loading

dlesnoff Jun 22, 2023 •

edited

Loading

dlesnoff commented Jun 27, 2023 •

edited

Loading