Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clean demos #189

Open
wants to merge 3 commits into
base: fix/bad-use-multisampling
Choose a base branch
from

Conversation

damienmontastier
Copy link
Collaborator

@damienmontastier damienmontastier commented Feb 16, 2025

This PR cleans up the usage demos in the documentation (those from version >V2.0) to improve readability. Although the demos have been streamlined, it was still essential to provide users with the complete source code. To achieve this, an expandable menu has been added below each demo, allowing users to view the demo's code.

I've also modified the demos in the documentation introduction. The tags were missing.


Are demos still too massive, or is that okay?

Because the imports can be removed, I just think it's important to keep <TresPerspectiveCamera /> to understand the level at which to activate <EffectComposerPmndrs />.

I haven't modified @Tinoooo demos (before version 2.0), I may do so later when we've agreed on a “basic model” of demo usage style.


The branch is deliberately based on the fix/bad-use-multisampling branch. I also based the PR directly on the bad-use-multisampling branch instead of main. I don't know if that's a good practice or not, you tell me!
Capture d’écran 2025-02-16 à 17 41 44

@damienmontastier damienmontastier added documentation Improvements or additions to documentation docs Improvements or additions to documentation labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant