[chore] migrate to eslint@8 and run --fix (#2256)

closes #2107 - updated related babel dependencies - bumped eslint - ran `yarn lint:js --fix` - added eslint ignore comments for some required non-camel-case properties
TryGhost · Feb 10, 2022 · 15f0aa7 · 15f0aa7
1 parent c7383b4
commit 15f0aa7
Show file tree

Hide file tree

Showing 93 changed files with 323 additions and 326 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,12 +1,18 @@
 /* eslint-env node */
 module.exports = {
     root: true,
-    parser: 'babel-eslint',
+    parser: '@babel/eslint-parser',
     parserOptions: {
         ecmaVersion: 2018,
         sourceType: 'module',
+        allowImportExportEverywhere: false,
         ecmaFeatures: {
+            globalReturn: false,
             legacyDecorators: true
+        },
+        requireConfigFile: false,
+        babelOptions: {
+            plugins: ['@babel/plugin-proposal-class-properties', ['@babel/plugin-proposal-decorators', {legacy: true}]]
         }
     },
     plugins: [

diff --git a/app/components/gh-alerts.js b/app/components/gh-alerts.js
@@ -11,5 +11,5 @@ export default class GhAlerts extends Component {
     @service notifications;
 
     @alias('notifications.alerts')
-    messages;
+        messages;
 }
diff --git a/app/components/gh-basic-dropdown.js b/app/components/gh-basic-dropdown.js
@@ -2,7 +2,7 @@ import BasicDropdown from 'ember-basic-dropdown/components/basic-dropdown';
 import {inject as service} from '@ember/service';
 
 class GhBasicDropdown extends BasicDropdown {
-    @service dropdown
+    @service dropdown;
 
     constructor() {
         super(...arguments);

diff --git a/app/components/gh-billing-update-button.js b/app/components/gh-billing-update-button.js
@@ -15,7 +15,7 @@ export default class GhBillingUpdateButton extends Component {
     subscription = null;
 
     @reads('billing.subscription.isActiveTrial')
-    showUpgradeButton;
+        showUpgradeButton;
 
     @action
     openBilling() {

diff --git a/app/components/gh-cm-editor.js b/app/components/gh-cm-editor.js
@@ -33,7 +33,7 @@ class CmEditorComponent extends Component {
     update = () => {};
 
     @boundOneWay('value')
-    _value; // make sure a value exists
+        _value; // make sure a value exists
 
     didReceiveAttrs() {
         super.didReceiveAttrs(...arguments);
@@ -77,7 +77,7 @@ class CmEditorComponent extends Component {
 
         scheduleOnce('afterRender', this, this._initCodeMirror);
     })
-    initCodeMirror;
+        initCodeMirror;
 
     _initCodeMirror() {
         let options = this.getProperties('lineNumbers', 'lineWrapping', 'indentUnit', 'mode', 'theme', 'autofocus');

diff --git a/app/components/gh-date-time-picker.js b/app/components/gh-date-time-picker.js
@@ -32,10 +32,10 @@ export default class GhDateTimePicker extends Component {
     setTypedDateError() {}
 
     @reads('settings.timezone')
-    blogTimezone;
+        blogTimezone;
 
     @or('dateError', 'timeError')
-    hasError;
+        hasError;
 
     @computed('_date', '_scratchDate')
     get dateValue() {

diff --git a/app/components/gh-launch-wizard/connect-stripe.js b/app/components/gh-launch-wizard/connect-stripe.js
@@ -13,7 +13,6 @@ export default class GhLaunchWizardConnectStripeComponent extends Component {
     @service ghostPaths;
     @service settings;
     @service store;
-    @service settings;
 
     @tracked hasActiveStripeSubscriptions = false;
     @tracked showDisconnectStripeConnectModal = false;

diff --git a/app/components/gh-member-activity-feed.js b/app/components/gh-member-activity-feed.js
@@ -19,7 +19,7 @@ class MemberActivity {
             iconClass: 'red-d2',
             tooltip: 'Email delivery failed'
         }
-    }
+    };
 
     constructor(props) {
         Object.assign(this, props);

diff --git a/app/components/gh-member-settings-form.js b/app/components/gh-member-settings-form.js
@@ -7,12 +7,12 @@ import {task} from 'ember-concurrency';
 import {tracked} from '@glimmer/tracking';
 
 export default class extends Component {
-    @service membersUtils
-    @service ghostPaths
-    @service ajax
-    @service store
-    @service feature
-    @service settings
+    @service membersUtils;
+    @service ghostPaths;
+    @service ajax;
+    @service store;
+    @service feature;
+    @service settings;
 
     constructor(...args) {
         super(...args);

diff --git a/app/components/gh-nav-menu/footer.js b/app/components/gh-nav-menu/footer.js
@@ -13,10 +13,10 @@ export default class Footer extends Component {
     @service feature;
 
     @and('config.clientExtensions.dropdown', 'session.user.isOwnerOnly')
-    showDropdownExtension;
+        showDropdownExtension;
 
     @match('router.currentRouteName', /^settings/)
-    isSettingsRoute;
+        isSettingsRoute;
 
     // equivalent to "left: auto; right: -20px"
     userDropdownPosition(trigger, dropdown) {

diff --git a/app/components/gh-nav-menu/main.js b/app/components/gh-nav-menu/main.js
@@ -34,27 +34,27 @@ export default class Main extends Component.extend(ShortcutsMixin) {
     shortcuts = null;
 
     @match('router.currentRouteName', /^settings\.integration/)
-    isIntegrationRoute;
+        isIntegrationRoute;
 
     // HACK: {{link-to}} should be doing this automatically but there appears to
     // be a bug in Ember that's preventing it from working immediately after login
     @equal('router.currentRouteName', 'site')
-    isOnSite;
+        isOnSite;
 
     @or('session.user.isAdmin', 'session.user.isEditor')
-    showTagsNavigation;
+        showTagsNavigation;
 
     @and('config.clientExtensions.menu', 'session.user.isOwnerOnly')
-    showMenuExtension;
+        showMenuExtension;
 
     @and('config.clientExtensions.script', 'session.user.isOwnerOnly')
-    showScriptExtension;
+        showScriptExtension;
 
     @reads('config.hostSettings.billing.enabled')
-    showBilling;
+        showBilling;
 
     @reads('settings.stripeConnectAccountId')
-    isStripeConnected;
+        isStripeConnected;
 
     init() {
         super.init(...arguments);
@@ -123,7 +123,7 @@ export default class Main extends Component.extend(ShortcutsMixin) {
             return false;
         }
     })
-    _loadMemberCountsTask;
+        _loadMemberCountsTask;
 
     _setIconStyle() {
         let icon = this.icon;

diff --git a/app/components/gh-notifications.js b/app/components/gh-notifications.js
@@ -11,5 +11,5 @@ export default class GhNotifications extends Component {
     @service notifications;
 
     @alias('notifications.notifications')
-    messages;
+        messages;
 }
diff --git a/app/components/gh-portal-links.js b/app/components/gh-portal-links.js
@@ -77,7 +77,7 @@ export default class GhPortalLinks extends Component {
             });
         }
     })
-    fetchProducts;
+        fetchProducts;
 
     @task(function* (id) {
         this.set('copiedPrice', id);
@@ -90,7 +90,7 @@ export default class GhPortalLinks extends Component {
         copyTextToClipboard(data);
         yield timeout(this.isTesting ? 50 : 3000);
     })
-    copyStaticLink;
+        copyStaticLink;
 
     @task(function* (interval) {
         this.set('copiedSignupInterval', interval);
@@ -103,5 +103,5 @@ export default class GhPortalLinks extends Component {
         copyTextToClipboard(data);
         yield timeout(this.isTesting ? 50 : 3000);
     })
-    copyProductSignupLink;
+        copyProductSignupLink;
 }
diff --git a/app/components/gh-post-settings-menu.js b/app/components/gh-post-settings-menu.js
@@ -25,43 +25,43 @@ export default class GhPostSettingsMenu extends Component {
     isViewingSubview = false;
 
     @alias('post.canonicalUrlScratch')
-    canonicalUrlScratch;
+        canonicalUrlScratch;
 
     @alias('post.customExcerptScratch')
-    customExcerptScratch;
+        customExcerptScratch;
 
     @alias('post.codeinjectionFootScratch')
-    codeinjectionFootScratch;
+        codeinjectionFootScratch;
 
     @alias('post.codeinjectionHeadScratch')
-    codeinjectionHeadScratch;
+        codeinjectionHeadScratch;
 
     @alias('post.metaDescriptionScratch')
-    metaDescriptionScratch;
+        metaDescriptionScratch;
 
     @alias('post.metaTitleScratch')
-    metaTitleScratch;
+        metaTitleScratch;
 
     @alias('post.ogDescriptionScratch')
-    ogDescriptionScratch;
+        ogDescriptionScratch;
 
     @alias('post.ogTitleScratch')
-    ogTitleScratch;
+        ogTitleScratch;
 
     @alias('post.twitterDescriptionScratch')
-    twitterDescriptionScratch;
+        twitterDescriptionScratch;
 
     @alias('post.twitterTitleScratch')
-    twitterTitleScratch;
+        twitterTitleScratch;
 
     @boundOneWay('post.slug')
-    slugValue;
+        slugValue;
 
     @boundOneWay('post.uuid')
-    uuidValue;
+        uuidValue;
 
     @or('metaDescriptionScratch', 'customExcerptScratch', 'post.excerpt')
-    seoDescription;
+        seoDescription;
 
     @or(
         'ogDescriptionScratch',
@@ -71,18 +71,18 @@ export default class GhPostSettingsMenu extends Component {
         'settings.description',
         ''
     )
-    facebookDescription;
+        facebookDescription;
 
     @or(
         'post.ogImage',
         'post.featureImage',
         'settings.ogImage',
         'settings.coverImage'
     )
-    facebookImage;
+        facebookImage;
 
     @or('ogTitleScratch', 'seoTitle')
-    facebookTitle;
+        facebookTitle;
 
     @or(
         'twitterDescriptionScratch',
@@ -92,32 +92,32 @@ export default class GhPostSettingsMenu extends Component {
         'settings.description',
         ''
     )
-    twitterDescription;
+        twitterDescription;
 
     @or(
         'post.twitterImage',
         'post.featureImage',
         'settings.twitterImage',
         'settings.coverImage'
     )
-    twitterImage;
+        twitterImage;
 
     @or('twitterTitleScratch', 'seoTitle')
-    twitterTitle;
+        twitterTitle;
 
     @or(
         'session.user.isOwnerOnly',
         'session.user.isAdminOnly',
         'session.user.isEditor'
     )
-    showVisibilityInput;
+        showVisibilityInput;
 
     @or(
         'session.user.isOwnerOnly',
         'session.user.isAdminOnly',
         'session.user.isEditor'
     )
-    showEmailNewsletter;
+        showEmailNewsletter;
 
     @computed('metaTitleScratch', 'post.titleScratch')
     get seoTitle() {

diff --git a/app/components/gh-post-settings-menu/email.js b/app/components/gh-post-settings-menu/email.js
@@ -26,16 +26,16 @@ export default class Email extends Component {
     close() {}
 
     @or('emailSubjectScratch', 'post.title')
-    emailSubject;
+        emailSubject;
 
     @alias('post.emailSubjectScratch')
-    emailSubjectScratch;
+        emailSubjectScratch;
 
     @oneWay('session.user.email')
-    testEmailAddress;
+        testEmailAddress;
 
     @not('mailgunIsEnabled')
-    mailgunError;
+        mailgunError;
 
     @computed(
         'settings.{mailgunApiKey,mailgunDomain,mailgunBaseUrl}',
@@ -109,7 +109,7 @@ export default class Email extends Component {
             }
         }
     }).drop())
-    sendTestEmail;
+        sendTestEmail;
 
     @task(function* () {
         let {email} = this.post;
@@ -136,5 +136,5 @@ export default class Email extends Component {
 
         return true;
     })
-    retryEmail;
+        retryEmail;
 }
diff --git a/app/components/gh-psm-tags-input.js b/app/components/gh-psm-tags-input.js
@@ -20,7 +20,7 @@ export default class GhPsmTagsInput extends Component {
         // ignorePunctuation means the # in internal tag names is ignored
         return tagA.name.localeCompare(tagB.name, undefined, {ignorePunctuation: true});
     })
-    availableTags;
+        availableTags;
 
     @computed('[email protected]')
     get availableTagNames() {

diff --git a/app/components/gh-psm-template-select.js b/app/components/gh-psm-template-select.js
@@ -75,5 +75,5 @@ export default class GhPsmTemplateSelect extends Component {
 
         this.set('activeTheme', activeTheme);
     })
-    loadActiveTheme;
+        loadActiveTheme;
 }
diff --git a/app/components/gh-search-input.js b/app/components/gh-search-input.js
@@ -42,7 +42,7 @@ export default class GhSearchInputComponent extends Component {
         fields: ['slug', 'name'],
         idField: 'slug',
         titleField: 'name'
-    }]
+    }];
 
     @action
     openSelected(selected) {

diff --git a/app/components/gh-simplemde.js b/app/components/gh-simplemde.js
@@ -117,5 +117,5 @@ export default class GhSimplemde extends TextArea {
 
         this.onEditorInit(this._editor);
     })
-    initSimpleMDE;
+        initSimpleMDE;
 }
diff --git a/app/components/gh-timezone-select.js b/app/components/gh-timezone-select.js
@@ -18,7 +18,7 @@ export default class GhTimezoneSelect extends Component {
     update = () => {};
 
     @mapBy('availableTimezones', 'name')
-    availableTimezoneNames;
+        availableTimezoneNames;
 
     @computed('timezone', 'availableTimezoneNames')
     get hasTimezoneOverride() {