Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back function between varname and optic #95

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Apr 9, 2024

The function was removed in #91, this PR puts it back, but adjusts the order to be consistent with Accessors.
Also added opcompose (_op_posite compose, alias of ).

@sunxd3 sunxd3 requested review from torfjelde and yebai and removed request for torfjelde April 9, 2024 05:30
src/varname.jl Outdated Show resolved Hide resolved
src/varname.jl Outdated Show resolved Hide resolved
src/varname.jl Outdated Show resolved Hide resolved
src/varname.jl Outdated Show resolved Hide resolved
@sunxd3 sunxd3 changed the title Add and function between varname and optic Bring back function between varname and optic Apr 9, 2024
@sunxd3
Copy link
Member Author

sunxd3 commented Apr 9, 2024

Much appreciated! @devmotion

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sunxd3 @devmotion -- looks good!

@yebai yebai merged commit a80a0f2 into main Apr 9, 2024
10 checks passed
@yebai yebai deleted the sunxd/add_composite_function branch April 9, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants