Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sql-versions-include.md #6022

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

JoanCamosTyk
Copy link
Contributor

@JoanCamosTyk JoanCamosTyk commented Feb 25, 2025

User description

For internal users - Please add a Jira DX PR ticket to the subject!



Preview Link


Description


Screenshots (if appropriate)


Checklist

  • I have added a preview link to the PR description.
  • I have reviewed the suggestions made by our AI (PR Agent) and updated them accordingly (spelling errors, rephrasing, etc.)
  • I have reviewed the guidelines for contributing to this repository.
  • I have read the technical guidelines for contributing to this repository.
  • Make sure you have started your change off our latest master.
  • For Tyk Members - Please add a Jira DX PR ticket to the subject!
  • For Tyk Members - I have added the appropriate release label to this PR:
    • If it is for a future release, label it as future-release and specify the version (e.g., future-release, 6.0).
    • If it should be merged into an older version, use the specific version label (e.g., 4.1, 5.1).
    • If no label is added, it will be assumed that the PR should be merged into the latest current version (e.g., 5.5) and master.

PR Type

Documentation


Description

  • Updated supported PostgreSQL versions in documentation.

  • Removed reference to PostgreSQL version 12.x.

  • Added reference to PostgreSQL version 17.x.


Changes walkthrough 📝

Relevant files
Documentation
sql-versions-include.md
Update PostgreSQL version support details                               

tyk-docs/content/shared/sql-versions-include.md

  • Updated the list of supported PostgreSQL versions.
  • Removed version 12.x from the list.
  • Added version 17.x to the list.
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Update

    Verify that the addition of PostgreSQL version 17.x is accurate and supported by Tyk 4.0. Ensure compatibility has been tested and documented.

    - [PostgreSQL](https://www.postgresql.org) version 13.x, 14.x, 15.x, 16.x, 17.x

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Ensure compatibility for newly added versions

    Verify that PostgreSQL version 17.x has been thoroughly tested and is fully
    supported by Tyk 4.0 to avoid potential compatibility issues.

    tyk-docs/content/shared/sql-versions-include.md [6]

    -- [PostgreSQL](https://www.postgresql.org) version 13.x, 14.x, 15.x, 16.x, 17.x
    +- [PostgreSQL](https://www.postgresql.org) version 13.x, 14.x, 15.x, 16.x
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion highlights the importance of verifying compatibility for the newly added PostgreSQL version 17.x, which is crucial to avoid potential issues. However, it is not actionable directly within the PR and requires external validation, slightly reducing its score.

    Medium

    Copy link

    netlify bot commented Feb 25, 2025

    PS. Pls add /docs/nightly to the end of url

    Name Link
    🔨 Latest commit 3203f31
    🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/67bd89c23ec8d100088dd76b
    😎 Deploy Preview https://deploy-preview-6022--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link

    netlify bot commented Feb 25, 2025

    PS. Pls add /docs/nightly to the end of url

    Name Link
    🔨 Latest commit 1a7983a
    🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/67bdb13dbf405b0008ac84ab
    😎 Deploy Preview https://deploy-preview-6022--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants