test merge #2859
Closed
test merge #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add top margin to `.tsd-breadcrumb` in mobile screen - Remove top margin from `.tsd-navigation.settings` - Remove top padding from `.col-sidebar` on single sidebar - Remove margin for `.site-menu` on larger screens
- Move selectors (`#tsd-toolbar-links`, tag selectors) to a relevant place. - Remove classes (`.table-cell`, `.no-caption`, `.tsd-toolbar-icon`), and merge their styles to other common classes.
…cript - **theme_search_index_not_available** - **theme_search_no_results** - theme_search_placeholder - **theme_search_no_recent_searches**
- Use HTML dialog element as popup - Use ARIA-spec compliant "combobox with list autocomplete" pattern for search - Add entry animations - Comment out affected dead code for keyboard event listeners
- store recent searches (that were clicked) in localStorage, with `tsd-search-recent` key - Omit `matchData` property in `res`'s type to make it compatible with recent searches stored in localStorage. - This implementation prevents broken links, but refs might change, changing the suggestions
- fix typo (requierd -> required) - Remove unnecessary try-catch - Add falsy check for document.getElementById argument to avoid console warning in firefox
All children of a listbox must be options, showing error message in an li tag without role=option was invalid. An alternative approach is to use another element with aria-live=polite attribute, to announce the results to the user. However, consecutive queries with no results wouldn't be announced (because the message would be the same), so add search query as part of the message to make it dynamic - Add a new element with aria-live and aria-atomic attributes for a helpful message - Remove unnecessary attribute selector for search results. - Add styles height/margin styles for non-empty elements only. - Add maxLength to input
- Add background-active and contrast-text css properties - update text-aside, menu-item-active color in light theme - break light and dark colors in separate selectors to make them easier to work with "contrast-text" slightly improves contrast. though, not enough to pass WCAG level AAA
|
Wrong repo 😮💨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[]#2825@include+ warn on empty regions + cleanuptargetbefore using it in regular expressions@inline@classwith mapped types can incorrectly handle properties #2842@includeand@includeCode@include+ warn on empty regions + cleanuptargetbefore using it in regular expressions@inline@classwith mapped types can incorrectly handle properties #2842getSupportedLanguagesreturning langs without translationsundefinedhrefs for excluded external refssetCurrentResulttosetNextResultmarkfor highlighting search matchesbodyselectors.statesetNextResult