-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CUDA build to GitHub Actions (and CMake clean-up) #1300
Conversation
KrisThielemans
commented
Dec 14, 2023
- add a GHA build with CUDA, whcih needed renaming of caches
- add missing source extensions in some CMakeLists.txt
9043e99
to
0d585cc
Compare
@markus-jehl this works all ok, but it is the first time that we test gcc 12 with CUDA on GHA. Sadly
the "blocks" test works. Any idea? (By the way, we need to set modality in these tests to avoid at least some warnings.) |
0d585cc
to
33d67b0
Compare
6ff806a
to
b8448b2
Compare
confirmed that |
@markus-jehl @danieldeidda any ideas? |
How does the downsampled viewgram look? If that one is still symmetric, then it is definitely in the interpolation. Otherwise it must be some difference in how float numbers are rounded |
This is very strange... I looked at the scanner definitions and the math checks out as far as I can tell. So it must be some weird floating point issue in how the cylinder is constructed for the downsampled scanner or similar. |
no problem in Debug build |
downsampled image in Debug mode occupies central 3 planes (out of 11). In RelWithDebug, it has 1 more non-zero plane, causing asymmetry. |
for the cylindrical scanner, the z-voxel size is 10mm, but the length of the cylinder is 40. So, this is sensitive to rounding. |
Symmetric cylinder object was not symmetric for the "cylinder" case on gcc-12 Release due to rounding error problems.
b8448b2
to
8ca178c
Compare
Should be fixed. @markus-jehl please have a look. |
That looks clean, thank you! |