Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Ge68 to radionuclide database #1338

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

danieldeidda
Copy link
Collaborator

No description provided.

@KrisThielemans KrisThielemans linked an issue Jan 22, 2024 that may be closed by this pull request
@KrisThielemans
Copy link
Collaborator

@PaulClegg can you check if these values are consistent with what Siemens has in their headers? (in particula rthe branching ratio).

@danieldeidda I cannot remember if we have any tests that check if the json files are well-formed. do You?

@danieldeidda
Copy link
Collaborator Author

@PaulClegg
Copy link

PaulClegg commented Jan 22, 2024 via email

@KrisThielemans
Copy link
Collaborator

Thanks @PaulClegg but you had a Ge68 as well?

@danieldeidda got the other numbers from some approved reference. Who knows where Siemens got their data from. At the moment, we use our numbers and ignore the values in the header. Maybe this is worth making explicit somewhere.

@danieldeidda
Copy link
Collaborator Author

Hi, Yes the numbers in STIR are from standardised measurements. The tables are from here :http://www.lnhb.fr/accueil/donnees-nucleaires/donnees-nucleaires-tableau/

for Ge68: http://www.lnhb.fr/nuclides/Ge-68_tables.pdf

@PaulClegg
Copy link

PaulClegg commented Jan 22, 2024 via email

@KrisThielemans
Copy link
Collaborator

@PaulClegg I remember it was in the Siemens .s.hdr. no?

@KrisThielemans
Copy link
Collaborator

@danieldeidda as we cannot add a comment to JSON files, what about adding a field "data-origin" specifying the URLs that you have. I think this can be done without any code changes, but might need a change in the doc. (I can't remember if it has to be present or not). Otherwise we will forget...

@danieldeidda
Copy link
Collaborator Author

I seem to remember we had put the link in the documentation, but maybe not. Yes JSON does not seem to allow comments

@PaulClegg
Copy link

PaulClegg commented Jan 22, 2024 via email

@KrisThielemans
Copy link
Collaborator

hmmm. you did show me a Ge-68 header...

@PaulClegg
Copy link

PaulClegg commented Jan 22, 2024 via email

@KrisThielemans KrisThielemans merged commit 51eb99b into UCL:master Jan 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add Germanium-68 to our radio-nuclide database
3 participants