-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scatter forward projector setter #1530
Merged
KrisThielemans
merged 5 commits into
UCL:master
from
robbietuk:scatter_forward_projector_setter
Nov 27, 2024
Merged
Scatter forward projector setter #1530
KrisThielemans
merged 5 commits into
UCL:master
from
robbietuk:scatter_forward_projector_setter
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ready to merge. |
KrisThielemans
requested changes
Nov 25, 2024
KrisThielemans
approved these changes
Nov 27, 2024
ah, sorry, can you add a line to |
I'll squash-merge if ok |
looks like there's a conflict with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Introduces the ability to set and retrieve a forward projector for scatter estimation, used in mask forward projection, in the ScatterEstimation class. Also adds a keymap parser.
Related issues
Fixes #1527
Checklist before requesting a review
documentation/release_XXX.md
has been updated with any functionality change (if applicable)