Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add PRODID and VERSION to .ics exports #344

Merged
merged 1 commit into from
Mar 23, 2019
Merged

Add PRODID and VERSION to .ics exports #344

merged 1 commit into from
Mar 23, 2019

Conversation

dshynkev
Copy link
Contributor

@dshynkev dshynkev commented Mar 23, 2019

This change is needed to conform to RFC 5545, which requires:

Property Name: PRODID
Conformance: The property MUST be specified once in an iCalendar object.

Property Name: VERSION
Conformance: This property MUST be specified once in an iCalendar object.

My hope is that this is also what caused #343, but I do not have access to iCal to check.

@dshynkev dshynkev requested review from bobqywei and AyushK1 March 23, 2019 18:16
@AyushK1
Copy link
Member

AyushK1 commented Mar 23, 2019

looks good 👍

@dshynkev dshynkev merged commit a66b2f6 into master Mar 23, 2019
@dshynkev dshynkev deleted the ical-fix branch March 23, 2019 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants