This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Do not add www. in webcal: link #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobqywei
approved these changes
Mar 29, 2019
|
Looks good, but yeah we should look into the certificate issue later. |
AyushK1
approved these changes
Mar 29, 2019
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our certificate is not valid for
www.uwflow.com(known issue: #320). As a result,webcal:links that reference that hostname will not work if the client enforces proper security, like Apple Calendar seems to do. This is likely the cause of #343 and similar reports. Stripping off thewww.prefix fixes the issue in Apple Calendar in my testing. Of course, we should eventually take care of the certificate issue as well.