Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: live switch celo quote for 100 percent #621

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Apr 22, 2024

We check the following metrics before we decide to increase traffic switch on CELO:

  • Is CELO still sampling at 10%, meanwhile live traffic switched at 1%?
    Based on the metrics, this appears to be the same:
Screenshot 2024-04-22 at 3 36 46 PM
  • Is the success rate on the CELO endpoint and on each CELO RPC call consistent?
    CELO endpoint shows the consistently high success rate:
Screenshot 2024-04-22 at 3 39 03 PM
  • Is the latency on the CELO endpoint consistent?
    CELO latency does not change after live switch:
Screenshot 2024-04-22 at 3 40 17 PM
  • Is the RPC call volume only slightly up after quote shadow sampling on CELO?
    CELO RPC call volume only shows minimum increase, which is important because when we live switch, we don't expect to see any further more RPC calls due to our optimized implementations:
Screenshot 2024-04-22 at 3 40 57 PM
  • Is the Shadow quoter faster than the current quoter on CELO?
    V3 shadow quoter shows consistently better latency then the current v3 quoter on CELO:
Screenshot 2024-04-22 at 3 42 48 PM

Is the quote accuracy always 100% between new v3 quoter and current v3 quoter?
The accuracy comparison shows it's always at 100%:
Screenshot 2024-04-22 at 3 44 00 PM

@jsy1218 jsy1218 self-assigned this Apr 22, 2024
Copy link
Collaborator

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to remove sampling then?

Copy link
Member Author

jsy1218 commented Apr 22, 2024

Do you want to remove sampling then?

Make sense

@jsy1218 jsy1218 force-pushed the jsy1218/live-switch-celo-quote-for-100-percent branch from 8963c35 to 4273f1d Compare April 22, 2024 23:14
@jsy1218 jsy1218 force-pushed the jsy1218/live-switch-celo-quote-for-100-percent branch from 4273f1d to 37022f4 Compare April 22, 2024 23:17
Copy link
Member Author

jsy1218 commented Apr 22, 2024

Merge activity

  • Apr 22, 7:17 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 22, 7:19 PM EDT: @jsy1218 merged this pull request with Graphite.

@jsy1218 jsy1218 merged commit e9d62b4 into main Apr 22, 2024
5 checks passed
@jsy1218 jsy1218 deleted the jsy1218/live-switch-celo-quote-for-100-percent branch April 22, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants