fix: activity id to chain id quote injector and lambda handler event #622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During container injector, we instantiate a new global logger with injector-sor, without request id, or any identifier that can identifier which request it's part of:
The reason for this is because, buildContainerInjected() is called as part of QuoteHandlerInjector('quoteInjector').build(), but we only start to get the request id from the lambda event within new QuoteHandler('quote', quoteInjectorPromise)
, within injector:
So this means we need to manually generate a new random identifier within injector-sor
activityId
, and pass into injector, so that we have the way to identify which request is this container injection from. In addition, because not every request needs the container injection, the activity id has to be optional. I verified in my local and can now see activityId popping up and tieing up the loggings within the same request:I also tested non-cold start scenario, and can see there's no activity id, only request id: