Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: live switch avax quote for 100 percent #624

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Apr 23, 2024

We check the following metrics before we decide to increase traffic switch on AVAX:

  • Is AVAX still sampling at 10%, meanwhile live traffic switched at 1%?
    Based on the metrics, this appears to be the same:
Screenshot 2024-04-23 at 9 36 12 AM
  • Is the success rate on the AVAX endpoint and on each AVAX RPC call consistent?
    AVAX endpoint shows the consistently high success rate:
Screenshot 2024-04-23 at 9 58 54 AM
  • Is the latency on the AVAX endpoint consistent?
    AVAX latency does not change after live switch:
Screenshot 2024-04-23 at 9 59 52 AM
  • Is the RPC call volume only slightly up after quote shadow sampling on AVAX?
    AVAX RPC call volume only shows minimum increase, which is important because when we live switch, we don't expect to see any further more RPC calls due to our optimized implementations:
Screenshot 2024-04-23 at 10 00 57 AM
  • Is the quote accuracy always 100% between new v3 quoter and current v3 quoter?
    The accuracy comparison shows it's always at 100%:
Screenshot 2024-04-23 at 10 02 40 AM

@jsy1218 jsy1218 self-assigned this Apr 23, 2024
Copy link
Member Author

jsy1218 commented Apr 23, 2024

Merge activity

  • Apr 23, 1:15 PM EDT: @jsy1218 started a stack merge that includes this pull request via Graphite.
  • Apr 23, 1:16 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 23, 1:19 PM EDT: @jsy1218 merged this pull request with Graphite.

@jsy1218 jsy1218 force-pushed the jsy1218/live-switch-avax-quote-for-100-percent branch from ad0d352 to 84f115d Compare April 23, 2024 17:16
@jsy1218 jsy1218 merged commit 9d79d1c into main Apr 23, 2024
5 checks passed
@jsy1218 jsy1218 deleted the jsy1218/live-switch-avax-quote-for-100-percent branch April 23, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants