Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[RPC Gateway Fallback Resign] Implement the online path (#601)" #627

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

rollingtumbling
Copy link
Contributor

@rollingtumbling rollingtumbling commented Apr 23, 2024

This reverts commit 5a9396d.

Beta cloud formation failed. We need to revert it then investigate.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rollingtumbling and the rest of your teammates on Graphite Graphite

@rollingtumbling rollingtumbling marked this pull request as ready for review April 23, 2024 20:57
@rollingtumbling rollingtumbling merged commit 70e0b88 into main Apr 23, 2024
5 checks passed
@rollingtumbling rollingtumbling deleted the 0423_revert_online_path_change branch April 23, 2024 21:00
rollingtumbling added a commit that referenced this pull request Apr 24, 2024
@rollingtumbling rollingtumbling requested a review from cgkol April 24, 2024 15:16
rollingtumbling added a commit that referenced this pull request Apr 24, 2024
rollingtumbling added a commit that referenced this pull request Apr 24, 2024
This is re-launch of #601.

The original PR's caused environmental variable size to be bigger than 4KB and thus cannot be deployed. Since then we've removed a few environmental variables from beta and prod RoutingLambda and cleaned some of the secrets' value that end up being in the environmental variables.

There is no code change compared with the [original](#601) (merged but [reverted](#627)) PR.
treeMan0301 added a commit to treeMan0301/uniswap-routing-api that referenced this pull request Oct 24, 2024
This is re-launch of Uniswap/routing-api#601.

The original PR's caused environmental variable size to be bigger than 4KB and thus cannot be deployed. Since then we've removed a few environmental variables from beta and prod RoutingLambda and cleaned some of the secrets' value that end up being in the environmental variables.

There is no code change compared with the [original](Uniswap/routing-api#601) (merged but [reverted](Uniswap/routing-api#627)) PR.
EnigmaGlimmer added a commit to EnigmaGlimmer/Uniswap_routing that referenced this pull request Dec 8, 2024
This is re-launch of Uniswap/routing-api#601.

The original PR's caused environmental variable size to be bigger than 4KB and thus cannot be deployed. Since then we've removed a few environmental variables from beta and prod RoutingLambda and cleaned some of the secrets' value that end up being in the environmental variables.

There is no code change compared with the [original](Uniswap/routing-api#601) (merged but [reverted](Uniswap/routing-api#627)) PR.
ap2000218 added a commit to ap2000218/UniswapRoutingApi that referenced this pull request Feb 12, 2025
This is re-launch of Uniswap/routing-api#601.

The original PR's caused environmental variable size to be bigger than 4KB and thus cannot be deployed. Since then we've removed a few environmental variables from beta and prod RoutingLambda and cleaned some of the secrets' value that end up being in the environmental variables.

There is no code change compared with the [original](Uniswap/routing-api#601) (merged but [reverted](Uniswap/routing-api#627)) PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants