fix: introduce dynamic FOT token list for on chain fetch fallback #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphite-app
bot
requested review from
uni-guillaume,
cgkol,
mikeki,
a team and
jsy1218
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (06/25/24)6 reviewers were added and 1 assignee was added to this PR based on 's automation. |
mikeki
approved these changes
Jun 25, 2024
jsy1218
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing dynamic FOT token list for on chain fetch fallback
This is a temporary solution to identify dynamic FOT addresses.
These are pre-calculated from our shadow sampling where we noticed differences in the fees returned by the on-chain fee fetcher vs GraphQL.
Once GraphQL exposes the
isDynamicFOTfield, we can remove this list (estimated Q3 2024).More details at https://linear.app/uniswap/issue/ROUTE-111/