Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMCL-1641: respect blend time when backing out of a heterogeneous blend #1038

Merged
merged 1 commit into from
Jan 30, 2025
Merged

CMCL-1641: respect blend time when backing out of a heterogeneous blend #1038

merged 1 commit into from
Jan 30, 2025

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Jan 30, 2025 •
edited
Loading

Purpose of this PR

CMCL-1641: In cases where blend time A->B is not the same as B->A, reversing a blend in will not always respect the desired blend time.

Description here: https://discussions.unity.com/t/i-dont-understand-the-cinemachine-camera-blend-duration-behavior/1592488

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@glabute glabute merged commit 198e87e into main Jan 30, 2025
4 of 70 checks passed
@glabute glabute deleted the dev/backing-out-of-hetero-blend branch January 30, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienduverne sebastienduverne Awaiting requested review from sebastienduverne sebastienduverne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glabute