Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCPA-437 hairtab reference #576

Draft
wants to merge 6 commits into
base: dev/feature/support-hair-workflow
Choose a base branch
from

Conversation

arejayelle
Copy link
Contributor

@arejayelle arejayelle commented Dec 19, 2023

Purpose of this PR

Ticket/Jira #: DOCPA-437

  • Update all references of two tabs to three tabs
  • Add hair section
  • Add relevant screenshot for hair section.

Testing

Functional Testing status:

Performance Testing status:

Overall Product Risks

Complexity:

Halo Effect:

Documentation & UX Writing

User facing text to review Details
User interface
Public API docs
Changelog
Documentation halo effect Jira link
User manual
Other docs

Additional information

Note to reviewers:

Reminder:

  • Add entry in CHANGELOG.md

@arejayelle arejayelle self-assigned this Dec 21, 2023
@thomas-tu thomas-tu self-requested a review January 3, 2024 18:36

The Hair tab helps you generate a groom from the imported Alembic file.

![The Import Settings window (Hair tab)](images/abc_import_options_hair.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two others screenshots in this page showing the Model/Material/Hair tabs. They should be also be updated I believe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is true! However, I discussed this with @sebastienduverne and the screenshots system will be getting overhauled soon so it's not vital to replace these screenshots yet. The sample information in the current screenshots have is meaningful and therefore it's better to keep these rather than having new images with all 3 tabs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I remember I said that – however for now there is no immediate plan to retake all screenshots across the doc (for context, it would be to switch to dark mode).
So if one of you could update the 3 consistently (reproduce what was shown as best as possible) and uniformly (get the same width and resolution for all), that would be cleaner. I can't really do it at the moment, I'm not set up for it.
Thanks!

@thomas-tu thomas-tu self-assigned this Jan 8, 2024
Copy link
Contributor

@sebastienduverne sebastienduverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed/edited the text and made a commit, also made a comment about the screenshots.
@thomas-tu it's in your hands now :)


The Hair tab helps you generate a groom from the imported Alembic file.

![The Import Settings window (Hair tab)](images/abc_import_options_hair.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I remember I said that – however for now there is no immediate plan to retake all screenshots across the doc (for context, it would be to switch to dark mode).
So if one of you could update the 3 consistently (reproduce what was shown as best as possible) and uniformly (get the same width and resolution for all), that would be cleaner. I can't really do it at the moment, I'm not set up for it.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants