feat/enum and forward ref support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiseck3
requested review from
jakub-sandomierz-deepsense-ai and
hubert-rutkowski85
rbiseck3
force-pushed
the
feat/add-enum-support
branch
from
fe93df7
to
6ba3584
Compare
jakub-sandomierz-deepsense-ai
approved these changes
Jul 2, 2024
| @@ -223,7 +280,7 @@ def fn(g: Input) -> Optional[Output]: | |||
|
|
|||
| def test_typed_dict(): | |||
| class Input(TypedDict): | |||
| x: int | |||
| x: "int" | |||
There was a problem hiding this comment.
Is this change necessary?
There was a problem hiding this comment.
Wanted to test the forward reference being resolved correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add conversion of enum values to json schema with added unit tests. Also properly resolve any typing that uses string and needs dereferencing.