-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds support in pipeline for voyage #3424
adds support in pipeline for voyage #3424
Conversation
What would be the best process of getting a review here? |
@@ -58,6 +58,14 @@ def get_embedder(self) -> BaseEmbeddingEncoder: | |||
) | |||
|
|||
return VertexAIEmbeddingEncoder(config=VertexAIEmbeddingConfig(**kwargs)) | |||
|
|||
elif self.embedding_provider == "voyage": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change "voyage" to "langchain-voyageai"? You can refer to: https://github.com/Unstructured-IO/unstructured/blob/main/unstructured/ingest/interfaces.py#L237
Hi @jeremydiba, Thank you for your contribution. We appreciate your contribution. However, I need to inform you that we have a new git repository for ingestion and this code seems to be already in there - https://github.com/Unstructured-IO/unstructured-ingest/blob/main/unstructured_ingest/v2/processes/embedder.py. The ingestion code in this repository is no longer under active development. We are not accepting further changes to this codebase at this time. Sorry for the inconvenience this may cause. If you have any questions or would like to discuss this further, please don't hesitate to reach out. |
No problem, thanks for the response! |
The following PR adds support for Voyage embedding models within the pipeline process.
Fixes Unstructured-IO/unstructured-ingest#54