feat: Add consistent aliases #362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangasta
reviewed
Feb 11, 2025
internal/commands/util.go
Outdated
Comment on lines
238
to
239
| fmt.Printf("⚠️ Deprecation Warning: The alias '%s' is deprecated and will be removed in a future release.\n", deprecatedAlias) | ||
| fmt.Printf(" Please use '%s' instead.\n\n", newCommand) |
There was a problem hiding this comment.
These could be outputted to stderr to avoid problems with parsing the output.
Warning level progress messages could also be used. Those are available through commands.Executor. That way the formatting would be in sync with warnings we output (here) when user cancel the operation with CTRL+C.
There was a problem hiding this comment.
@kangasta I changed to print the messages to stderr. That is a good change.
I do not understand the changes you are proposing to the progress message. The deprecation message is shown right before the command executes so I am not sure why is related to the progress of the command execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.