feat(account): add login command #375
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kangasta
commented
Feb 11, 2025
kangasta
commented
- Sync with feat(config): added initial keyring support (#83) #350
- Wait for hub support
kangasta
commented
Feb 11, 2025
|
|
||
| exec.PushProgressSuccess(msg) | ||
|
|
||
| return output.None{}, nil |
There was a problem hiding this comment.
Should maybe output the token if saving to keyring fails 🤔
kangasta
commented
Feb 11, 2025
| return commands.HandleError(exec, msg, fmt.Errorf("failed to save token to keyring: %w", err)) | ||
| } | ||
|
|
||
| exec.PushProgressSuccess(msg) |
There was a problem hiding this comment.
Update progress message to something like New authentication token created and saved to system keyring.
kangasta
commented
Feb 11, 2025
|
|
||
| err = keyring.Set("UpCloud", "", token) | ||
| if err != nil { | ||
| return commands.HandleError(exec, msg, fmt.Errorf("failed to save token to keyring: %w", err)) |
There was a problem hiding this comment.
Do we want to use config file as fallback? I guess the file should be generic to be able to use it also with e.g. Terraform provider 🤔
kangasta
commented
Feb 12, 2025
Comment on lines
+40
to
+45
| if token == "" { | ||
| http.Redirect(w, req, getURL("error"), http.StatusSeeOther) | ||
| return | ||
| } | ||
| s.token = token | ||
| http.Redirect(w, req, getURL("success"), http.StatusSeeOther) |
There was a problem hiding this comment.
Should the token be delivered with fetch request instead of redirects?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.