Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][HorizontalScroll] Обрезаются тени у внутренних элементов #2860

Open
inomdzhon opened this issue Jul 19, 2022 · 3 comments · Fixed by #2862
Open

[Bug][HorizontalScroll] Обрезаются тени у внутренних элементов #2860

inomdzhon opened this issue Jul 19, 2022 · 3 comments · Fixed by #2862
Assignees
@inomdzhon
Labels
cmp:horizontal-scroll type:bug

Comments

@inomdzhon
Copy link
Contributor

Описание

Из-за overflow: hidden у .vkuiHorizontalScroll обрезаются тени (см. Рис. 1)

image

Рис. 1 Обрезается тень у HorizontalScrollArrow. Ссылка на песочницу Tabs v4.33.4

В целом если у переданного children будут тени, то они тоже обрежутся (см. Рис. 2)

image

Рис. 2 Обрезается тень у <Tabs mode="accent" />. Ссылка на песочницу Tabs PR #2781

Окружение

Версия библиотеки: v4.33.4
@inomdzhon inomdzhon self-assigned this Jul 19, 2022
This was referenced Jul 19, 2022
Merged
Merged
@inomdzhon
Copy link
Contributor Author

В #2862 ошибся в стилях 😞 Надо на хосте удалить св-во overflow-x: hidden

@inomdzhon inomdzhon reopened this Jul 21, 2022
@inomdzhon inomdzhon mentioned this issue Jul 22, 2022
Closed
@SevereCloud SevereCloud moved this to In Review in VKUI Aug 1, 2022
@SevereCloud SevereCloud added this to VKUI Aug 1, 2022
@inomdzhon
Copy link
Contributor Author

Проблема решена за счёт добавления отступов для Tabs

см. PR #2781

Repository owner moved this from 👀 In Review to ✅ Done in VKUI Oct 17, 2022
@ElForastero
Copy link
Contributor

image

Всё ещё обрезается тень. Возможно это ок, возможно нет.

@ElForastero ElForastero reopened this Jun 22, 2023
@github-project-automation github-project-automation bot moved this from ✅ Done to 🔜 To do in VKUI Jun 22, 2023
@inomdzhon inomdzhon removed this from VKUI Jun 22, 2023
@inomdzhon inomdzhon added this to VKUI Jun 22, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inomdzhon inomdzhon

Labels
cmp:horizontal-scroll type:bug
Projects
VKUI
Status: 🗃 Backlog
Milestone
No milestone
2 participants
@ElForastero @inomdzhon