Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tabs,TabsItem): tokenized #2781

Merged
merged 5 commits into from
Aug 1, 2022
Merged

feat(Tabs,TabsItem): tokenized #2781

merged 5 commits into from
Aug 1, 2022

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Jul 1, 2022 •
edited
Loading

Чеклист перевода компонента на vkui-tokens

  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens (пример такого PR #2647)
  • Дизайн ревью

Дополнительно

Появился новый параметр (см. подробности в PR)

  • status

@inomdzhon inomdzhon requested a review from a team as a code owner July 1, 2022 15:24
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c7293d:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 255.72 KB (+0.26% 🔺)
JS (gzip) 76.81 KB (+0.25% 🔺)
JS (brotli) 64.76 KB (+0.21% 🔺)
JS, unstable 30.07 KB (0%)
CSS 277.49 KB (+0.6% 🔺)
CSS (gzip) 37.83 KB (+0.3% 🔺)
CSS (brotli) 30.32 KB (+0.36% 🔺)
CSS, unstable 1.12 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2781/

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022 •
edited
Loading

Changed screenshots

tabs-android-light-1
tabs-ios-light-1
tabs-vkcom-light-1

Code coverage

lines3883 / 495178.42%
statements3953 / 504778.32%
functions843 / 106179.45%
branches3426 / 477071.82%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 3c7293d

@inomdzhon inomdzhon force-pushed the Tabs-and-TabsItem-tokenized branch from 95c7863 to 98d3156 Compare July 4, 2022 15:29
@BlackySoul
Copy link
Contributor

Кажется, изменения в ветке ещё поправили вот это:

@inomdzhon inomdzhon force-pushed the Tabs-and-TabsItem-tokenized branch 2 times, most recently from 58996c0 to c54db9e Compare July 14, 2022 08:55
@inomdzhon inomdzhon mentioned this pull request Jul 14, 2022
Closed
@SevereCloud
Copy link
Contributor

Кажется, изменения в ветке ещё поправили вот это:

Выглядит намного лучше, но с иконкой нет многоточия

Chrome Firefox
image image

@inomdzhon inomdzhon force-pushed the Tabs-and-TabsItem-tokenized branch from c54db9e to 7f2cb08 Compare July 15, 2022 17:02
@inomdzhon inomdzhon requested a review from a team as a code owner July 15, 2022 17:02
@inomdzhon
Copy link
Contributor Author

Кажется, изменения в ветке ещё поправили вот это:

Выглядит намного лучше, но с иконкой нет многоточия

Chrome Firefox
image image

Выглядит как баг Firefox

Видео 1

Изменял вот этот пример http://jsfiddle.net/QNJnw/

firefox.mov
Видео 2

Изменял вот этот пример https://codepen.io/chriscoyier/full/zqedEr

firefox.2.mov

Поиски issue и игра со св-ами ни привели к результату.

Вообще баг не выглядит критичным. Раз это проблема Firefox, то надо ждать фикса от них. И чтобы кто-нибудь открыл им issue 😄

@inomdzhon inomdzhon force-pushed the Tabs-and-TabsItem-tokenized branch 4 times, most recently from 759841f to d12bda1 Compare July 22, 2022 14:22
@SevereCloud SevereCloud removed the request for review from a team July 25, 2022 08:26
@inomdzhon inomdzhon force-pushed the Tabs-and-TabsItem-tokenized branch from 6294b91 to 86ec6d3 Compare July 28, 2022 15:02
eugpoloz
eugpoloz suggested changes Jul 29, 2022
View reviewed changes
BlackySoul
BlackySoul previously approved these changes Aug 1, 2022
View reviewed changes
eugpoloz
eugpoloz previously approved these changes Aug 1, 2022
View reviewed changes
@inomdzhon
fix(Tabs,TabsItem,Counter): fix for code and design review
3c7293d 
* Add `useAdaptivity()` for subscribe to `sizeY`
* Fix jsdoc of Tabs mode prop
* Add Appearance tokens for TabsItem accent mode styles
* Fix selector and remove unused styles
@inomdzhon inomdzhon force-pushed the Tabs-and-TabsItem-tokenized branch from 23ad772 to 3c7293d Compare August 1, 2022 09:25
@inomdzhon inomdzhon merged commit 5d19e86 into master Aug 1, 2022
@inomdzhon inomdzhon deleted the Tabs-and-TabsItem-tokenized branch August 1, 2022 09:43
@inomdzhon inomdzhon mentioned this pull request Aug 1, 2022
Merged
@inomdzhon inomdzhon mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugpoloz eugpoloz eugpoloz approved these changes

@BlackySoul BlackySoul BlackySoul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@inomdzhon @BlackySoul @SevereCloud @eugpoloz