Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppRoot: always show body scrollbar for full integration #1367

Closed
wants to merge 4 commits into from
Closed

AppRoot: always show body scrollbar for full integration #1367

wants to merge 4 commits into from

Conversation

ewgenius
Copy link
Contributor

@ewgenius ewgenius commented Feb 4, 2021 •
edited
Loading

#1337

Проблема

  • при появлении вертикального скроллбара, ширина страницы меняется и это вызывает баги с некоторыми компонентами зависящими от нее (Gallery, FixedLayout, ...)

Решение

  • AppRoot автоматически добавляет overflow: scroll на body
  • Если заранее известно, что в приложении не потребуется вертикальный скролл - можно отключить через
<AppRoot showScrollbar={false}  />

Before

before

After

after

Desktop:

image

Mobile (не проявляется никак):

mobile

@ewgenius ewgenius requested a review from a team as a code owner February 4, 2021 09:36
@ewgenius ewgenius changed the title AppRoot: always show body scrollbar for full inttegration AppRoot: always show body scrollbar for full integration Feb 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2021

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/1367/

@ewgenius ewgenius mentioned this pull request Feb 4, 2021
Open
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2021 •
edited
Loading

Code coverage

lines1697 / 351148.33%
statements1715 / 359247.74%
functions377 / 81846.09%
branches873 / 263733.11%

Generated by 🚫 dangerJS against b460420

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2021 •
edited
Loading

size-limit report 📦

Path Size
JS 46.15 KB (+0.11% 🔺)
JS, unstable 6.61 KB (0%)
CSS 27.18 KB (+0.06% 🔺)
CSS, unstable 463 B (0%)

@ewgenius ewgenius force-pushed the fix/app-root-scroll branch from 0b49147 to 12aa0c7 Compare February 4, 2021 09:58
@eolme
Copy link
Contributor

eolme commented Feb 4, 2021

Не, такой вариант в чистом виде не пойдет, пользователи Windows не будут в восторге.

Да и выглядит это плохо - всегда справа отступ на декстопах.

@ewgenius ewgenius closed this Sep 9, 2021
@SevereCloud SevereCloud deleted the fix/app-root-scroll branch September 9, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewgenius @eolme