Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FixedLayout): revert to 1364 PR number #2472

Merged
merged 3 commits into from
May 13, 2022

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented May 11, 2022

Старое описание

Поправил центровку при фиксированной ширине.

Здесь #2414 (коммит 230b4dc) не учёл это.

Использовал старый добрый метод 😄

left: 0;
right: 0;
margin-left: auto;
margin-right: auto;

UPD

После изменения #2414 (коммит 230b4dc) в v4.29.1 сломалась:

  1. центровка при фиксированной ширине

    Демо

    Было
    before

    Стало
    after

  2. [Bug][PanelHeader] Съезжает хеадер в многоколончатом интерфейсе #2475

поэтому ревертнул коммит 230b4dc


fix #2475

@inomdzhon inomdzhon requested a review from a team as a code owner May 11, 2022 13:04
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ef1bab:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

size-limit report 📦

Path Size
JS 76.85 KB (0%)
JS, unstable 26.24 KB (0%)
CSS 42.61 KB (+0.01% 🔺)
CSS, unstable 1015 B (0%)

@github-actions
Copy link
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2472/

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

Code coverage

lines3719 / 475478.22%
statements3790 / 484678.20%
functions839 / 104480.36%
branches3074 / 438870.05%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 6ef1bab

@eolme
Copy link
Contributor

eolme commented May 11, 2022

e2e должны как раз такое отлавливать

@fedorov-xyz
Copy link
Contributor

Согласен с Антоном. Не хватает скриншотного теста на такое отображение шапки и других FixedLayout'ов.

Copy link
Contributor

@SevereCloud SevereCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Исправление сломало `SplitLayout`, в котором в текущей версии важно, чтобы у `FixedLayout` было `left: auto`
@inomdzhon inomdzhon changed the title fix(FixedLayout): correct centering fix(FixedLayout): revert to 1364 PR number May 12, 2022
@inomdzhon
Copy link
Contributor Author

Ревертнул изменение (поправил описание), т.к. не нашёл способа поправить ситуацию #2475 без брейкинг чендж.

Проблема #2422 не критична.

SevereCloud
SevereCloud previously approved these changes May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][PanelHeader] Съезжает хеадер в многоколончатом интерфейсе
5 participants