Remove withAdaptivity #2601
Merged
Remove withAdaptivity #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5a8dd7d:
|
size-limit report 📦
|
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2601/ |
eugpoloz
reviewed
May 25, 2022
src/testing/e2e/utils.tsx
Outdated
| } from "../../components/AdaptivityProvider/AdaptivityContext"; | ||
| import { AdaptivityProps, withAdaptivity } from "../../hoc/withAdaptivity"; | ||
| import { withAdaptivity } from "../../hoc/withAdaptivity"; |
There was a problem hiding this comment.
Может, тут тоже выкинем и перейдем на AdaptivityProvider?
inomdzhon
reviewed
May 26, 2022
eugpoloz
reviewed
Jun 1, 2022
| viewHeight: true, | ||
| hasMouse: true, | ||
| }); | ||
| ModalRoot.displayName = "ModalRoot"; |
There was a problem hiding this comment.
И тут тоже можно выпилить displayName.
inomdzhon
reviewed
Jun 1, 2022
Comment on lines
-4223
to
-4244
| caniuse-lite@^1.0.0, caniuse-lite@^1.0.30001286, caniuse-lite@^1.0.30001297: | ||
| version "1.0.30001300" | ||
| resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001300.tgz#11ab6c57d3eb6f964cba950401fd00a146786468" | ||
| integrity sha512-cVjiJHWGcNlJi8TZVKNMnvMid3Z3TTdDHmLDzlOdIiZq138Exvo0G+G0wTdVYolxKb4AYwC+38pxodiInVtJSA== | ||
|
|
||
| caniuse-lite@^1.0.30001109, caniuse-lite@^1.0.30001280: | ||
| version "1.0.30001284" | ||
| resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001284.tgz#d3653929ded898cd0c1f09a56fd8ca6952df4fca" | ||
| integrity sha512-t28SKa7g6kiIQi6NHeOcKrOrGMzCRrXvlasPwWC26TH2QNdglgzQIRUuJ0cR3NeQPH+5jpuveeeSFDLm2zbkEw== | ||
|
|
||
| caniuse-lite@^1.0.30001165: | ||
| version "1.0.30001177" | ||
| resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001177.tgz" | ||
|
|
||
| caniuse-lite@^1.0.30001219: | ||
| version "1.0.30001243" | ||
| resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001243.tgz#d9250155c91e872186671c523f3ae50cfc94a3aa" | ||
| integrity sha512-vNxw9mkTBtkmLFnJRv/2rhs1yufpDfCkBZexG3Y0xdOH2Z/eE/85E4Dl5j1YUN34nZVsSp6vVRFQRrez9wJMRA== | ||
|
|
||
| caniuse-lite@^1.0.30001332: | ||
| caniuse-lite@^1.0.0, caniuse-lite@^1.0.30001109, caniuse-lite@^1.0.30001165, caniuse-lite@^1.0.30001219, caniuse-lite@^1.0.30001280, caniuse-lite@^1.0.30001286, caniuse-lite@^1.0.30001297, caniuse-lite@^1.0.30001332: | ||
| version "1.0.30001344" | ||
| resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001344.tgz#8a1e7fdc4db9c2ec79a05e9fd68eb93a761888bb" |
There was a problem hiding this comment.
А ты командой yarn дедупликации сделал?
There was a problem hiding this comment.
Это я npx browserslist@latest --update-db запускал
inomdzhon
reviewed
Jun 1, 2022
| export const Epic: React.FC<EpicProps & AdaptivityContextInterface> = ( | ||
| props | ||
| ) => { | ||
| export const Epic: React.FC<EpicProps> = (props) => { |
There was a problem hiding this comment.
Заметил, что сейчас в файлик сразу и именованный экспорт, и экспорт по умолчанию
There was a problem hiding this comment.
Оставил только именованный
eugpoloz
approved these changes
Jun 2, 2022
This reverts commit bef28dd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link #2350