Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ActionSheet, ActionSheetItem): Tokenize #2852

Merged
merged 2 commits into from
Aug 18, 2022
Merged

feat(ActionSheet, ActionSheetItem): Tokenize #2852

merged 2 commits into from
Aug 18, 2022

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Jul 18, 2022 •
edited
Loading

Чеклист перевода компонента на vkui-tokens

  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens (пример такого PR #2647)
  • Исключаем проверки типа platform === ANDROID (пример такого PR #2653) (остались, есть платформенные отличия)
  • В стилях компонента не осталось платформенных селекторов (остались, есть платформенные отличия)
  • В tsx компонента не осталось логики, которая зависит от платформы (остались, есть платформенные отличия)
  • Дизайн-ревью

@BlackySoul BlackySoul requested a review from a team as a code owner July 18, 2022 06:54
@BlackySoul BlackySoul linked an issue Jul 18, 2022 that may be closed by this pull request
[Feature] Токенизировать ActionSheet #2504
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 18, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 663aa68:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 260.59 KB (-0.02% 🔽)
JS (gzip) 77.24 KB (+0.05% 🔺)
JS (brotli) 65.22 KB (+0.24% 🔺)
JS, unstable 30.13 KB (0%)
CSS 274.07 KB (-0.43% 🔽)
CSS (gzip) 37.7 KB (-0.29% 🔽)
CSS (brotli) 30.21 KB (-0.3% 🔽)
CSS, unstable 1.12 KB (0%)

@github-actions
Copy link
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2852/

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022 •
edited
Loading

Warnings
⚠️

3 changed screenshots found — review & update them via "Update Screenshots" action before merging.
⚠️

Some screenshots were manually modified in this PR - please use the action next time.

Changed screenshots

actionsheet-android-light-w_2-1
actionsheet-ios-light-w_2-1
actionsheet-vkcom-light-w_2-1

Code coverage

lines3798 / 487577.90%
statements3867 / 497077.80%
functions843 / 106479.22%
branches3387 / 470971.92%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 0b03f77

@eugpoloz
Copy link
Contributor

@BlackySoul а что со скриншотами?

@eugpoloz eugpoloz self-requested a review July 18, 2022 12:59
@BlackySoul BlackySoul force-pushed the feat/2504/ActionSheet_tokenize branch 4 times, most recently from e8a94c4 to 4d5b27e Compare July 20, 2022 07:21
@BlackySoul
Copy link
Contributor Author

@BlackySoul а что со скриншотами?

Обновила

@BlackySoul BlackySoul force-pushed the feat/2504/ActionSheet_tokenize branch 2 times, most recently from aaaaab8 to e799953 Compare July 26, 2022 10:07
@BlackySoul BlackySoul force-pushed the feat/2504/ActionSheet_tokenize branch from e799953 to f6d92af Compare July 28, 2022 03:16
@BlackySoul BlackySoul force-pushed the feat/2504/ActionSheet_tokenize branch from 0369a92 to 0b03f77 Compare July 28, 2022 04:02
@BlackySoul BlackySoul merged commit 836054c into master Aug 18, 2022
@BlackySoul BlackySoul deleted the feat/2504/ActionSheet_tokenize branch August 18, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon left review comments

@stoope stoope stoope left review comments

@eugpoloz eugpoloz eugpoloz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать ActionSheetItem [Feature] Токенизировать ActionSheet
4 participants
@BlackySoul @eugpoloz @inomdzhon @stoope