Fix: Closure Issue in ToolFactory.from_openapi_schema #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Python closure issue in callback creation loop for multiple endpoints in OpenAPI schemas.
Issue
In
ToolFactory.py
, all callbacks created in thefrom_openapi_schema
method capture the same reference to thepath
variable. By execution time, all callbacks reference the last path in the loop, causing all API calls to be routed to the last endpoint regardless of intended destination.Fix
_create_callback_for_path
to create isolated closurespath
andmethod
valuesTesting
Verified with a multi-endpoint schema that each endpoint correctly routes to the appropriate path.
Related Issues
Resolves cases where API calls are incorrectly routed to the wrong endpoint when multiple endpoints exist in the schema.