#554 Header looks different on inner pages; needs to be same #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jeromehardaway
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When you click on the pages available from the Modules page: https://vetswhocode.io/curriculum/subjectsthe header looks different from what's on all the other pages. (See homepage for the right example)
The header needs to remain the same across all pages of this webapp.
Solution:
On src/pages/curriculum/[slug].tsx, I saw an inconsistency on line number 3: import Layout01 from "@layout/layout-02";
I changed it to import Layout01 from "@layout/layout-01";
Now, we can see the same header across all pages on Modules.
Before:
After:
