fix: rename inconsistent variable names for app update

Viren070 · Mar 19, 2024 · 59c6e12 · 59c6e12
1 parent 259d9f8
commit 59c6e12
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/gui/frames/settings/app_settings_frame.py b/src/gui/frames/settings/app_settings_frame.py
@@ -31,14 +31,14 @@ def build_frame(self):
         self.appearance_mode_variable = customtkinter.StringVar()
         self.colour_theme_variable = customtkinter.StringVar()
         self.use_yuzu_installer_variable = customtkinter.StringVar()
-        self.check_for_update_variable = customtkinter.StringVar()
+        self.check_for_app_update_variable = customtkinter.StringVar()
         self.disable_automatic_updates_variable = customtkinter.StringVar()
         self.use_yuzu_installer_variable.set(self.settings.yuzu.use_yuzu_installer)
         self.appearance_mode_variable.set(self._get_appearance_mode().title())
         self.colour_theme_variable.set(os.path.basename(customtkinter.ThemeManager._currently_loaded_theme).replace("-", " ").replace(".json", "").title())
         self.delete_files_variable = customtkinter.StringVar()
         self.delete_files_variable.set(self.settings.app.delete_files)
-        self.check_for_update_variable.set(self.settings.app.check_for_app_updates)
+        self.check_for_app_update_variable.set(self.settings.app.check_for_app_updates)
         self.disable_automatic_updates_variable.set(self.settings.app.disable_automatic_updates)
 
         colour_themes = get_colour_themes(os.path.join(self.parent_frame.parent_frame.root_dir, "assets", "themes"))
@@ -57,7 +57,7 @@ def build_frame(self):
         ttk.Separator(self, orient="horizontal").grid(row=9, columnspan=4, sticky="ew")
 
         customtkinter.CTkLabel(self, text="Check for app updates on startup").grid(row=10, column=0, padx=10, pady=10, sticky="w")
-        customtkinter.CTkCheckBox(self, text="", variable=self.check_for_update_variable, onvalue="True", offvalue="False", command=self.change_app_update_option).grid(row=10, column=2, padx=(50, 0), pady=10, sticky="ew")
+        customtkinter.CTkCheckBox(self, text="", variable=self.check_for_app_update_variable, onvalue="True", offvalue="False", command=self.change_app_update_option).grid(row=10, column=2, padx=(50, 0), pady=10, sticky="ew")
         ttk.Separator(self, orient="horizontal").grid(row=11, columnspan=4, sticky="ew")
 
         customtkinter.CTkLabel(self, text="Disable automatic emulator updates").grid(row=12, column=0, padx=10, pady=10, sticky="w")
@@ -129,7 +129,7 @@ def change_delete_files_option(self):
         self.update_settings()
 
     def change_app_update_option(self):
-        self.settings.app.check_for_app_updates = self.check_for_update_variable.get()
+        self.settings.app.check_for_app_updates = self.check_for_app_update_variable.get()
         self.update_settings()
 
     def change_emulator_update_option(self):

diff --git a/src/settings/settings.py b/src/settings/settings.py
@@ -200,7 +200,7 @@ def update_file(self):
                 "appearance_mode": self.app.appearance_mode,
                 "colour_theme": self.app.colour_theme,
                 "delete_files": self.app.delete_files,
-                "check_for_updates": self.app.check_for_app_updates,
+                "check_for_app_updates": self.app.check_for_app_updates,
                 "disable_automatic_updates": self.app.disable_automatic_updates,
                 "ask_firmware": self.app.ask_firmware
             }