Skip to content

Commit

Permalink
DEVX-9003: Add max_bitrate to Video::Archives (#321)
Browse files Browse the repository at this point in the history
* Add max_bitrate as option to Video::Archives#start method
  • Loading branch information
superchilled authored Feb 10, 2025
1 parent 131be52 commit 58e55c3
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 9 deletions.
4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 7.29.0

* Adds `max_bitrate` as an option to the `Video::Archives#start` method. [#321](https://github.com/Vonage/vonage-ruby-sdk/pull/321)

# 7.28.0

* Adds templates and template fragments to the Verify v2 implementation. [#318](https://github.com/Vonage/vonage-ruby-sdk/pull/318)
Expand Down
5 changes: 4 additions & 1 deletion lib/vonage/keys.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,19 @@ def camelcase(hash)
'remove_stream',
'screenshare_type',
'session_id',
'output_mode',
'stream_mode',
'archive_mode',
'multi_archive_tag',
'language_code',
'max_duration',
'partial_captions',
'status_callback_url',
'audio_rate',
'phone_number',
'hashed_phone_number',
'max_age'
'max_age',
'max_bitrate'
]
hash.transform_keys do |k|
if exceptions.include?(k.to_s)
Expand Down
2 changes: 1 addition & 1 deletion lib/vonage/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# typed: strong

module Vonage
VERSION = '7.28.0'
VERSION = '7.29.0'
end
12 changes: 7 additions & 5 deletions lib/vonage/video/archives.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,21 @@ def info(archive_id:)
#
# @param [required, String] :session_id
#
# @param [optional, String] :hasAudio
# @param [optional, String] :has_audio
#
# @param [optional, String] :hasVideo
# @param [optional, String] :has_video
#
# @param [optional, String] :name
#
# @param [optional, String] :outputMode
# @param [optional, String] :output_mode
#
# @param [optional, String] :resolution
#
# @param [optional, String] :streamMode
# @param [optional, String] :stream_mode
#
# @param [optional, String] :multiArchiveTag
# @param [optional, String] :multi_archive_tag
#
# @param [optional, String] :max_bitrate
#
# @param [optional, Hash] :layout
#
Expand Down
6 changes: 4 additions & 2 deletions test/vonage/video/archives_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,17 @@ def test_start_method_with_optional_params
request_params = {
sessionId: video_session_id,
resolution: '640x480',
streamMode: 'auto'
streamMode: 'auto',
maxBitrate: 200000
}

stub_request(:post, uri).with(body: request_params).to_return(response)

assert_kind_of Vonage::Response, archives.start(
session_id: video_session_id,
resolution: '640x480',
stream_mode: 'auto'
stream_mode: 'auto',
max_bitrate: 200000
)
end

Expand Down

0 comments on commit 58e55c3

Please sign in to comment.