Define permissions policy within the worklet #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 11, 2023
When LoadBidderWorklet()/LoadSellerWorklet(), calculate and pass in the permissions policy state to the worklet environment: get each policy's enabled state by calling rfh->permissions_policy()->IsFeatureEnabledForOrigin() against the script (worklet) origin. Explainer PR: WICG/turtledove#420 Bug: 1403364 Change-Id: I85577d8d67850c739526222609a4415a78ce248a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133845 Reviewed-by: Qingxin Wu <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1091383}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 11, 2023
… check" This reverts commit afe8f9c. Reason for revert: cause build failed on https://ci.chromium.org/ui/p/chromium/builders/ci/Win%20x64%20Builder/129351/overview Original change's description: > [FLEDGE] implement the private-aggregation permissions policy check > > When LoadBidderWorklet()/LoadSellerWorklet(), calculate and pass > in the permissions policy state to the worklet environment: get each > policy's enabled state by calling > rfh->permissions_policy()->IsFeatureEnabledForOrigin() against > the script (worklet) origin. > > Explainer PR: WICG/turtledove#420 > > Bug: 1403364 > Change-Id: I85577d8d67850c739526222609a4415a78ce248a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133845 > Reviewed-by: Qingxin Wu <[email protected]> > Commit-Queue: Yao Xiao <[email protected]> > Reviewed-by: Daniel Cheng <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1091383} Bug: 1403364 Change-Id: I4eaab3e4482df74bc797f75956cecc45c91e8215 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4157692 Commit-Queue: Victor Tan <[email protected]> Owners-Override: Jonathan Ross <[email protected]> Reviewed-by: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1091408}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 12, 2023
… check" This is a reland of commit afe8f9c Original change's description: > [FLEDGE] implement the private-aggregation permissions policy check > > When LoadBidderWorklet()/LoadSellerWorklet(), calculate and pass > in the permissions policy state to the worklet environment: get each > policy's enabled state by calling > rfh->permissions_policy()->IsFeatureEnabledForOrigin() against > the script (worklet) origin. > > Explainer PR: WICG/turtledove#420 > > Bug: 1403364 > Change-Id: I85577d8d67850c739526222609a4415a78ce248a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133845 > Reviewed-by: Qingxin Wu <[email protected]> > Commit-Queue: Yao Xiao <[email protected]> > Reviewed-by: Daniel Cheng <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1091383} Bug: 1403364 Change-Id: I3dafea9031001438773642c575640bdc542e8cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4157177 Commit-Queue: Yao Xiao <[email protected]> Reviewed-by: Qingxin Wu <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1091592}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.