Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure OAuth1 signature is created as per the spec #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure OAuth1 signature is created as per the spec #65

wants to merge 1 commit into from

Conversation

AlexC
Copy link
Contributor

@AlexC AlexC commented May 21, 2015

No description provided.

sblaz added a commit to sblaz/OAuth1 that referenced this pull request May 29, 2015
sblaz added a commit to sblaz/OAuth1 that referenced this pull request Jun 5, 2015
…correct-oauth-signature-creation

Conflicts:
	lib/class-wp-json-authentication-oauth1.php
@AlexC
Copy link
Contributor Author

AlexC commented Jun 10, 2015

Update to replace another urldecode with rawurldecode ... fixes issues with signature that contains "+" (they were replaced with spaces)

@sblaz
Copy link

sblaz commented Jun 25, 2015

I think the 2 rawurlencode() calls on line 627 might be unnecessary. I was seeing a double-encoding of my oauth_callback parameter value and it appears an earlier call to normalize_parameters() takes care of things correctly.

@coderkevin
Copy link

In my case, normalize_parameters() is really messing up my already partially encoded parameters, so by removing normalize_parameters() instead, I was able to keep the rawurldecode() calls.

See: #91

I have created a PR which merges your changes with AlexC's and removes normalize_parameters() in favor of encoding them in the join_with_equals_sign() function: #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants